src/ia32/lithium-codegen-ia32.cc - Issue 19647019: Removed usesless test instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 19647019: Removed usesless test instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added comment Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 54ae715d0a40aa8486765c2cb104f26b76866ba3..f92ab17499022b92bceb1f51e5760c32a5bfad08 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3782,8 +3782,7 @@ void LCodeGen::EmitIntegerMathAbs(LMathAbs* instr) {

__ test(input_reg, Operand(input_reg));

Label is_positive;

__ j(not_sign, &is_positive);

- __ neg(input_reg);

- __ test(input_reg, Operand(input_reg));

+ __ neg(input_reg); // Sets flags.

DeoptimizeIf(negative, instr->environment());

__ bind(&is_positive);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »