Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 19647019: Removed usesless test instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added comment Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3764 matching lines...) Expand 10 before | Expand all | Expand 10 after
3775 3775
3776 __ bind(&done); 3776 __ bind(&done);
3777 } 3777 }
3778 3778
3779 3779
3780 void LCodeGen::EmitIntegerMathAbs(LMathAbs* instr) { 3780 void LCodeGen::EmitIntegerMathAbs(LMathAbs* instr) {
3781 Register input_reg = ToRegister(instr->value()); 3781 Register input_reg = ToRegister(instr->value());
3782 __ test(input_reg, Operand(input_reg)); 3782 __ test(input_reg, Operand(input_reg));
3783 Label is_positive; 3783 Label is_positive;
3784 __ j(not_sign, &is_positive); 3784 __ j(not_sign, &is_positive);
3785 __ neg(input_reg); 3785 __ neg(input_reg); // Sets flags.
3786 __ test(input_reg, Operand(input_reg));
3787 DeoptimizeIf(negative, instr->environment()); 3786 DeoptimizeIf(negative, instr->environment());
3788 __ bind(&is_positive); 3787 __ bind(&is_positive);
3789 } 3788 }
3790 3789
3791 3790
3792 void LCodeGen::DoMathAbs(LMathAbs* instr) { 3791 void LCodeGen::DoMathAbs(LMathAbs* instr) {
3793 // Class for deferred case. 3792 // Class for deferred case.
3794 class DeferredMathAbsTaggedHeapNumber: public LDeferredCode { 3793 class DeferredMathAbsTaggedHeapNumber: public LDeferredCode {
3795 public: 3794 public:
3796 DeferredMathAbsTaggedHeapNumber(LCodeGen* codegen, LMathAbs* instr) 3795 DeferredMathAbsTaggedHeapNumber(LCodeGen* codegen, LMathAbs* instr)
(...skipping 2702 matching lines...) Expand 10 before | Expand all | Expand 10 after
6499 FixedArray::kHeaderSize - kPointerSize)); 6498 FixedArray::kHeaderSize - kPointerSize));
6500 __ bind(&done); 6499 __ bind(&done);
6501 } 6500 }
6502 6501
6503 6502
6504 #undef __ 6503 #undef __
6505 6504
6506 } } // namespace v8::internal 6505 } } // namespace v8::internal
6507 6506
6508 #endif // V8_TARGET_ARCH_IA32 6507 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698