Issue 19647019: Removed usesless test instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19647019: Removed usesless test instruction. (Closed)

Created:
7 years, 5 months ago by Sven Panne

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed usesless test instruction. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15847

Patch Set 2 : Added comment #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/19647019/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/19647019/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode3785 src/ia32/lithium-codegen-ia32.cc:3785: __ neg(input_reg); nit: Maybe add a "// Sets ...

7 years, 5 months ago (2013-07-24 08:30:11 UTC) #2

Sven Panne

Nit addressed, landing... https://codereview.chromium.org/19647019/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/19647019/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode3785 src/ia32/lithium-codegen-ia32.cc:3785: __ neg(input_reg); On 2013/07/24 08:30:11, Michael ...

7 years, 5 months ago (2013-07-24 08:31:42 UTC) #3

Sven Panne

7 years, 5 months ago (2013-07-24 08:32:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15847 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19647019: Removed usesless test instruction. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added comment #

Messages