Issue 1964673002: Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1964673002: Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services). (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Delete JSEchoTest.ShareEchoService -- it tests the wrong-way ServiceProvider (exposed_services). (exposed_services is going to be removed.) R=vardhan@google.com BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/2396e1a344da78fc5d8ac5be33b1ad731d36def8

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -32 lines)			Patch
M	services/js/echo_apptest.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	services/js/test/echo.js	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	services/js/test/echo_service.mojom	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Dependent Patchsets:

Issue 1965563002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 7 months ago (2016-05-09 23:12:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2396e1a344da78fc5d8ac5be33b1ad731d36def8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages