tracing/tracing/results2html.html - Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html

Unified Diff: tracing/tracing/results2html.html

Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/results2html.html

diff --git a/tracing/tracing/results2html.html b/tracing/tracing/results2html.html

new file mode 100644

index 0000000000000000000000000000000000000000..7196adbe427b94d6dcc326611a66d4cb9235a427

--- /dev/null

+++ b/tracing/tracing/results2html.html

@@ -0,0 +1,25 @@

+<!DOCTYPE html>

petrcermak 2016/05/18 10:43:20 Why is this file called results2html.html? Wouldn'

benjhayden 2016/05/18 18:23:33 I was following the lead of trace2html.html. I'm n

eakuefner 2016/05/18 18:39:55 I, too, find the name results2html.html confusing.

+<!--

+Use of this source code is governed by a BSD-style license that can be

+found in the LICENSE file.

+-->

+<link rel="import" href="/tracing/metrics/value_set.html">

+<link rel="import" href="/tracing/ui/value_set_view.html">

+<tr-ui-value-set-view id="values"></tr-ui-value-set-view>

+<script>

+'use strict';

+window.values = new tr.metrics.ValueList();

petrcermak 2016/05/18 10:43:21 Shouldn't this be ValueSet?

benjhayden 2016/05/18 18:23:34 Done.

+document.addEventListener('DOMContentLoaded', function() {

+ var valueSetView = document.getElementById('values');

+ valueSetView.values = values;

petrcermak 2016/05/18 10:43:20 Please use |window.values| to make it explicit whe

benjhayden 2016/05/18 18:23:33 Done.

+});

+</script>

+<!--

+Telemetry will append script tags that import ValueSets into window.values.

nednguyen 2016/05/18 02:44:44 Remove the "Telemetry" & replace this with "result

benjhayden 2016/05/18 18:23:33 I couldn't find "results_view_generator". Html2Out

eakuefner 2016/05/18 18:39:54 Actually, this points at a broader design issue --

+-->

« telemetry/telemetry/web_perf/timeline_based_measurement.py ('K') | « tracing/tracing/metrics/value_set.html ('k') | no next file » | no next file with comments »