tracing/tracing/results2html.html - Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html

Side by Side Diff: tracing/tracing/results2html.html

Issue 1964663003: [telemetry] Add Html2OutputFormatter for generating results2.html (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	petrcermak 2016/05/18 10:43:20 Why is this file called results2html.html? Wouldn' Why is this file called results2html.html? Wouldn't something like results2_template.html make more sense? benjhayden 2016/05/18 18:23:33 I was following the lead of trace2html.html. I'm n Show quoted text On 2016/05/18 at 10:43:20, petrcermak wrote: > Why is this file called results2html.html? Wouldn't something like results2_template.html make more sense? I was following the lead of trace2html.html. I'm not sure how to figure out what the name should be. I'd think that "_template.html" would contain layout slugs to be replaced (which this does not), and would not need vulcanization (which this does). But if you're sure that "results2_template.html" is the right name, then I'd be happy to change it. :-) eakuefner 2016/05/18 18:39:55 I, too, find the name results2html.html confusing. Show quoted text On 2016/05/18 at 18:23:33, benjhayden_chromium wrote: > On 2016/05/18 at 10:43:20, petrcermak wrote: > > Why is this file called results2html.html? Wouldn't something like results2_template.html make more sense? > > I was following the lead of trace2html.html. I'm not sure how to figure out what the name should be. > I'd think that "_template.html" would contain layout slugs to be replaced (which this does not), and would not need vulcanization (which this does). > But if you're sure that "results2_template.html" is the right name, then I'd be happy to change it. :-) I, too, find the name results2html.html confusing. I'd prefer results2_template.html.
	2 <!--

	3 Copyright 2016 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <link rel="import" href="/tracing/metrics/value_set.html">

	9 <link rel="import" href="/tracing/ui/value_set_view.html">

	10

	11 <tr-ui-value-set-view id="values"></tr-ui-value-set-view>

	12

	13 <script>

	14 'use strict';

	15

	16 window.values = new tr.metrics.ValueList();
	petrcermak 2016/05/18 10:43:21 Shouldn't this be ValueSet? Shouldn't this be ValueSet? benjhayden 2016/05/18 18:23:34 Done. Show quoted text On 2016/05/18 at 10:43:21, petrcermak wrote: > Shouldn't this be ValueSet? Done.
	17

	18 document.addEventListener('DOMContentLoaded', function() {

	19 var valueSetView = document.getElementById('values');

	20 valueSetView.values = values;
	petrcermak 2016/05/18 10:43:20 Please use \|window.values\| to make it explicit whe Please use \|window.values\| to make it explicit where the variable comes from. benjhayden 2016/05/18 18:23:33 Done. Show quoted text On 2016/05/18 at 10:43:20, petrcermak wrote: > Please use \|window.values\| to make it explicit where the variable comes from. Done.
	21 });

	22 </script>

	23 <!--

	24 Telemetry will append script tags that import ValueSets into window.values.
	nednguyen 2016/05/18 02:44:44 Remove the "Telemetry" & replace this with "result Remove the "Telemetry" & replace this with "results_view_generator" benjhayden 2016/05/18 18:23:33 I couldn't find "results_view_generator". Html2Out Show quoted text On 2016/05/18 at 02:44:44, nednguyen wrote: > Remove the "Telemetry" & replace this with "results_view_generator" I couldn't find "results_view_generator". Html2OutputFormatter? eakuefner 2016/05/18 18:39:54 Actually, this points at a broader design issue -- Show quoted text On 2016/05/18 at 18:23:33, benjhayden_chromium wrote: > On 2016/05/18 at 02:44:44, nednguyen wrote: > > Remove the "Telemetry" & replace this with "results_view_generator" > > I couldn't find "results_view_generator". Html2OutputFormatter? Actually, this points at a broader design issue -- we should consider exposing the Html2OutputFormatter logic through run_metric as well. Maybe add a module to tracing/metrics (results_view_builder maybe better than results_view_generator?) and then make sure that it's possible to call that from run_metric?
	25 -->

OLD	NEW

« telemetry/telemetry/web_perf/timeline_based_measurement.py ('K') | « tracing/tracing/metrics/value_set.html ('k') | no next file » | no next file with comments »