Fix mash shelf alignment change layout regression.

Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/b444acaa9b30c266084bb42b4dbb91f34bc13f00
Cr-Commit-Position: refs/heads/master@{#392415}

[msw, 2016-05-09 19:19:02]

Description was changed from

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
==========

to

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
==========

[msw, 2016-05-09 19:19:27]

Hey James, please take a look; thanks!

[James Cook, 2016-05-09 19:39:36]

LGTM with a suggestion

https://codereview.chromium.org/1964633002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/1964633002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:525: if
(aura::GetMusWindow(shelf_->GetNativeWindow()))
I think ash::Shell::GetInstance()->in_mus() would be clearer, since it doesn't
conflate the mus-check with the window-existance-check.

[msw, 2016-05-09 19:49:40]

Description was changed from

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
==========

to

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[msw, 2016-05-09 19:49:40]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-05-09 19:50:00]

+TBR'ing Scott for OWNERS review.

https://codereview.chromium.org/1964633002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/1964633002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:525: if
(aura::GetMusWindow(shelf_->GetNativeWindow()))
On 2016/05/09 19:39:36, James Cook wrote:
> I think ash::Shell::GetInstance()->in_mus() would be clearer, since it doesn't
> conflate the mus-check with the window-existance-check.

Done.

[msw, 2016-05-09 19:50:08]

The CQ bit was checked by msw@chromium.org

[msw, 2016-05-09 19:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1964633002/#ps20001
(title: "Use ash::Shell::GetInstance()->in_mus() instead.")

[commit-bot: I haz the power, 2016-05-09 19:50:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964633002/20001

[commit-bot: I haz the power, 2016-05-09 20:32:23]

Description was changed from

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-05-09 20:32:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 20:34:43]

Description was changed from

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG=603369
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/b444acaa9b30c266084bb42b4dbb91f34bc13f00
Cr-Commit-Position: refs/heads/master@{#392415}
==========

[commit-bot: I haz the power, 2016-05-09 20:34:44]

Patchset 2 (id:??) landed as
https://crrev.com/b444acaa9b30c266084bb42b4dbb91f34bc13f00
Cr-Commit-Position: refs/heads/master@{#392415}

[sky, 2016-05-12 15:06:22]

LGTM - thank for fixing this James!

[James Cook, 2016-05-12 15:58:05]

On 2016/05/12 15:06:22, sky wrote:
> LGTM - thank for fixing this James!

For the record, msw fixed it, so kudos to him. :-)