Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964603002: [es8] Throw SyntaxError when trying to tail call a direct eval. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@stc-strict-mode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es8] Throw SyntaxError when trying to tail call a direct eval. BUG=v8:4999, v8:4915 LOG=N Committed: https://crrev.com/11efb976fa85f938100c371a79e88d29e4289174 Cr-Commit-Position: refs/heads/master@{#36126}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 5 chunks +25 lines, -1 line 0 comments Download
A + test/message/syntactic-tail-call-of-eval.js View 1 chunk +1 line, -1 line 0 comments Download
A test/message/syntactic-tail-call-of-eval.out View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call-parsing.js View 2 chunks +20 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1955393002 Patch 1

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964603002/1
4 years, 7 months ago (2016-05-09 19:08:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964603002/20001
4 years, 7 months ago (2016-05-09 19:12:21 UTC) #5
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-09 19:25:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 19:46:15 UTC) #9
rossberg
lgtm
4 years, 7 months ago (2016-05-10 09:17:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964603002/20001
4 years, 7 months ago (2016-05-10 09:30:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-10 09:32:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 09:33:46 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/11efb976fa85f938100c371a79e88d29e4289174
Cr-Commit-Position: refs/heads/master@{#36126}

Powered by Google App Engine
This is Rietveld 408576698