Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1955393002: [es8] Throw SyntaxError when tail call expressions occur in non-strict mode. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es8] Throw SyntaxError when tail call expressions occur in non-strict mode. BUG=v8:4915 LOG=N Committed: https://crrev.com/bcb1b8732a3b929f1bf8442a4ebcbd43f9d90cec Cr-Commit-Position: refs/heads/master@{#36105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -77 lines) Patch
M src/messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +11 lines, -6 lines 0 comments Download
M test/message/syntactic-tail-call-in-binop-lhs.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-binop-lhs.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-binop-rhs.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-binop-rhs.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-comma.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-comma.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-extends.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-extends.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-for-in.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-for-in.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-for-of.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-for-of.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-logical-and.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-logical-and.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-logical-or.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-logical-or.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-subclass.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-subclass.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-try.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-try.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-try-catch-finally.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-try-catch-finally.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-in-try-try-catch-finally.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-in-try-try-catch-finally.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-inside-member-expr.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-inside-member-expr.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/syntactic-tail-call-of-identifier.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-of-identifier.out View 1 chunk +1 line, -1 line 0 comments Download
A + test/message/syntactic-tail-call-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
A test/message/syntactic-tail-call-sloppy.out View 1 chunk +4 lines, -0 lines 0 comments Download
M test/message/syntactic-tail-call-without-return.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/syntactic-tail-call-without-return.out View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/tail-call.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call.js View 4 chunks +117 lines, -0 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call-parsing.js View 4 chunks +8 lines, -9 lines 0 comments Download
A + test/mjsunit/es8/syntactic-tail-call-parsing-sloppy.js View 5 chunks +85 lines, -44 lines 0 comments Download
M test/mjsunit/es8/syntactic-tail-call-simple.js View 6 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1964603002 Patch 20001

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955393002/1
4 years, 7 months ago (2016-05-09 10:56:20 UTC) #2
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-09 10:56:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 11:25:52 UTC) #6
rossberg
lgtm
4 years, 7 months ago (2016-05-09 11:39:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955393002/1
4 years, 7 months ago (2016-05-09 11:39:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 11:41:45 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 11:42:41 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bcb1b8732a3b929f1bf8442a4ebcbd43f9d90cec
Cr-Commit-Position: refs/heads/master@{#36105}

Powered by Google App Engine
This is Rietveld 408576698