Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Issue 1964483002: Revert of [Extensions] Update more bindings and allow for multiple feature access (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Update more bindings and allow for multiple feature access (patchset #2 id:40001 of https://codereview.chromium.org/1945433002/ ) Reason for revert: This may have caused a blink bindings perf regression: crbug.com/610248. Speculatively reverting and will reland if it's not the issue. Original issue's description: > [Extensions] Update more bindings and allow for multiple feature access > > Update more of the native handler bindings and allow for handler > functions that are called by multiple features. > > BUG=591164 > > Committed: https://crrev.com/908ac08879c13a2c74573e88c0ca9d3f1f69eacd > Cr-Commit-Position: refs/heads/master@{#392182} TBR=asargent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591164 Committed: https://crrev.com/c827ac207ee330c2fc1423f6796ee017166a524b Cr-Commit-Position: refs/heads/master@{#392308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -82 lines) Patch
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M extensions/renderer/blob_native_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M extensions/renderer/context_menus_custom_bindings.cc View 1 chunk +1 line, -4 lines 0 comments Download
M extensions/renderer/file_system_natives.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 3 chunks +2 lines, -5 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 4 chunks +35 lines, -60 lines 0 comments Download
M extensions/renderer/set_icon_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Devlin
Created Revert of [Extensions] Update more bindings and allow for multiple feature access
4 years, 7 months ago (2016-05-09 13:32:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964483002/1
4 years, 7 months ago (2016-05-09 13:32:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 14:18:01 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:21:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c827ac207ee330c2fc1423f6796ee017166a524b
Cr-Commit-Position: refs/heads/master@{#392308}

Powered by Google App Engine
This is Rietveld 408576698