Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: extensions/renderer/object_backed_native_handler.h

Issue 1964483002: Revert of [Extensions] Update more bindings and allow for multiple feature access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/file_system_natives.cc ('k') | extensions/renderer/object_backed_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/object_backed_native_handler.h
diff --git a/extensions/renderer/object_backed_native_handler.h b/extensions/renderer/object_backed_native_handler.h
index f90189afb04f9af9d614fd72b924c9b52a2af6e0..974abe18600ccb3208f8f4f62e25d275d292b9c9 100644
--- a/extensions/renderer/object_backed_native_handler.h
+++ b/extensions/renderer/object_backed_native_handler.h
@@ -32,10 +32,10 @@
v8::Isolate* GetIsolate() const;
+ protected:
typedef base::Callback<void(const v8::FunctionCallbackInfo<v8::Value>&)>
HandlerFunction;
- protected:
// Installs a new 'route' from |name| to |handler_function|. This means that
// NewInstance()s of this ObjectBackedNativeHandler will have a property
// |name| which will be handled by |handler_function|.
@@ -44,7 +44,7 @@
// and are never called back into, therefore it's safe for |handler_function|
// to bind to base::Unretained.
//
- // |feature_name[s]| corresponds to the api feature the native handler is used
+ // |feature_name| corresponds to the api feature the native handler is used
// for. If the associated ScriptContext does not have access to that feature,
// the |handler_function| is not invoked.
// TODO(devlin): Deprecate the version that doesn't take a |feature_name|.
@@ -52,9 +52,6 @@
const HandlerFunction& handler_function);
void RouteFunction(const std::string& name,
const std::string& feature_name,
- const HandlerFunction& handler_function);
- void RouteFunction(const std::string& name,
- const std::vector<std::string>& feature_names,
const HandlerFunction& handler_function);
ScriptContext* context() const { return context_; }
« no previous file with comments | « extensions/renderer/file_system_natives.cc ('k') | extensions/renderer/object_backed_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698