Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1964393002: [GN] New template convert_plist to convert a plist file to another format. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] New template convert_plist to convert a plist file to another format. Add a new target convert_plist to invoke "plutil -convert" only on a given plist file. This is used as iOS needs to convert all plist to binary in bundle, including plist that are not Info.plist files. Fix ios_info_plist and info_plist templates to also forward "visibility" from the invoker. BUG=459705 Committed: https://crrev.com/7f441707e74fd96a04ecdd0c97f1f66d83e7bf5d Cr-Commit-Position: refs/heads/master@{#392924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M build/config/ios/rules.gni View 1 chunk +5 lines, -1 line 0 comments Download
M build/config/mac/base_rules.gni View 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 7 months ago (2016-05-11 08:16:44 UTC) #2
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-11 14:48:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964393002/1
4 years, 7 months ago (2016-05-11 14:48:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 14:51:39 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 14:52:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f441707e74fd96a04ecdd0c97f1f66d83e7bf5d
Cr-Commit-Position: refs/heads/master@{#392924}

Powered by Google App Engine
This is Rietveld 408576698