Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1964383002: Fullscreen / mouselock: Always auto-accept (even if flag disabled). (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
palmer, scheib, Dan Beam
CC:
chromium-reviews, scheib+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fullscreen / mouselock: Always auto-accept (even if flag disabled). This is the start of removing the old behaviour (when the simplified-fullscreen-ui flag disabled). Has no effect when the flag is enabled (the default). Lots of code can now be deleted, but saving that for a follow-up. BUG=610900 Committed: https://crrev.com/0f3e1f7950e232e69c8604741ef1b65529d6217a Cr-Commit-Position: refs/heads/master@{#393427}

Patch Set 1 #

Patch Set 2 : Added bug reference. #

Patch Set 3 : Fix FullscreenControllerInteractiveBrowserTest. #

Patch Set 4 : Content settings handler: Behave as if simplified flag is enabled. #

Patch Set 5 : Also remove setting from OIB. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -79 lines) Patch
M chrome/browser/ui/exclusive_access/fullscreen_controller.cc View 1 1 chunk +4 lines, -35 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/exclusive_access/mouse_lock_controller.cc View 1 1 chunk +4 lines, -22 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 1 chunk +8 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (13 generated)
Matt Giuca
Starting the cleanup of the old flag code.
4 years, 7 months ago (2016-05-12 03:11:48 UTC) #3
Matt Giuca
4 years, 7 months ago (2016-05-12 03:14:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964383002/20001
4 years, 7 months ago (2016-05-12 03:14:39 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/226370)
4 years, 7 months ago (2016-05-12 04:06:20 UTC) #8
scheib
LGTM
4 years, 7 months ago (2016-05-12 04:22:51 UTC) #9
Matt Giuca
tapted FYI, I am deleting this ShouldPrompt check from the parameterized test (because neither mode ...
4 years, 7 months ago (2016-05-12 07:20:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964383002/40001
4 years, 7 months ago (2016-05-12 07:20:40 UTC) #13
Matt Giuca
+dbeam: OWNERS on content_settings_handler.cc. I'll do a fuller cleanup later but for this CL I ...
4 years, 7 months ago (2016-05-12 07:34:37 UTC) #17
Matt Giuca
+palmer: Owners on content_settings.cc.
4 years, 7 months ago (2016-05-12 08:09:13 UTC) #19
Dan Beam
lgtm
4 years, 7 months ago (2016-05-12 18:37:19 UTC) #20
palmer
lgtm
4 years, 7 months ago (2016-05-12 18:50:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964383002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964383002/100001
4 years, 7 months ago (2016-05-13 01:08:49 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 7 months ago (2016-05-13 01:56:37 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 01:58:27 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0f3e1f7950e232e69c8604741ef1b65529d6217a
Cr-Commit-Position: refs/heads/master@{#393427}

Powered by Google App Engine
This is Rietveld 408576698