Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc

Issue 1964383002: Fullscreen / mouselock: Always auto-accept (even if flag disabled). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also remove setting from OIB. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 7 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
8 #include "chrome/browser/fullscreen.h" 8 #include "chrome/browser/fullscreen.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 break; 96 break;
97 case SIMPLIFIED: 97 case SIMPLIFIED:
98 command_line->AppendSwitchASCII(switches::kEnableFeatures, 98 command_line->AppendSwitchASCII(switches::kEnableFeatures,
99 features::kSimplifiedFullscreenUI.name); 99 features::kSimplifiedFullscreenUI.name);
100 break; 100 break;
101 default: 101 default:
102 NOTREACHED(); 102 NOTREACHED();
103 } 103 }
104 } 104 }
105 105
106 // Whether the test should be prompting the user (i.e. non-simplified UI).
107 bool ShouldPrompt() { return GetParam() == PROMPTING; }
108
109 private: 106 private:
110 DISALLOW_COPY_AND_ASSIGN(ParamaterizedFullscreenControllerInteractiveTest); 107 DISALLOW_COPY_AND_ASSIGN(ParamaterizedFullscreenControllerInteractiveTest);
111 }; 108 };
112 109
113 void FullscreenControllerInteractiveTest::ToggleTabFullscreen( 110 void FullscreenControllerInteractiveTest::ToggleTabFullscreen(
114 bool enter_fullscreen) { 111 bool enter_fullscreen) {
115 ToggleTabFullscreen_Internal(enter_fullscreen, true); 112 ToggleTabFullscreen_Internal(enter_fullscreen, true);
116 } 113 }
117 114
118 // |ToggleTabFullscreen| should not need to tolerate the transition failing. 115 // |ToggleTabFullscreen| should not need to tolerate the transition failing.
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 browser(), embedded_test_server()->GetURL(kFullscreenMouseLockHTML)); 718 browser(), embedded_test_server()->GetURL(kFullscreenMouseLockHTML));
722 719
723 ASSERT_FALSE(IsFullscreenBubbleDisplayed()); 720 ASSERT_FALSE(IsFullscreenBubbleDisplayed());
724 721
725 // Lock the mouse with a user gesture. 722 // Lock the mouse with a user gesture.
726 ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait( 723 ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait(
727 browser(), ui::VKEY_1, false, false, false, false, 724 browser(), ui::VKEY_1, false, false, false, false,
728 chrome::NOTIFICATION_MOUSE_LOCK_CHANGED, 725 chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
729 content::NotificationService::AllSources())); 726 content::NotificationService::AllSources()));
730 ASSERT_TRUE(IsFullscreenBubbleDisplayed()); 727 ASSERT_TRUE(IsFullscreenBubbleDisplayed());
731 if (ShouldPrompt()) {
732 ASSERT_TRUE(IsMouseLockPermissionRequested());
733 ASSERT_FALSE(IsMouseLocked());
734
735 // Accept mouse lock.
736 AcceptCurrentFullscreenOrMouseLockRequest();
737 }
738 ASSERT_TRUE(IsMouseLocked()); 728 ASSERT_TRUE(IsMouseLocked());
739 ASSERT_TRUE(IsFullscreenBubbleDisplayed()); 729 ASSERT_TRUE(IsFullscreenBubbleDisplayed());
740 730
741 // Unlock the mouse from target, make sure it's unlocked. 731 // Unlock the mouse from target, make sure it's unlocked.
742 ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait( 732 ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait(
743 browser(), ui::VKEY_U, false, false, false, false, 733 browser(), ui::VKEY_U, false, false, false, false,
744 chrome::NOTIFICATION_MOUSE_LOCK_CHANGED, 734 chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
745 content::NotificationService::AllSources())); 735 content::NotificationService::AllSources()));
746 ASSERT_FALSE(IsMouseLocked()); 736 ASSERT_FALSE(IsMouseLocked());
747 ASSERT_FALSE(IsFullscreenBubbleDisplayed()); 737 ASSERT_FALSE(IsFullscreenBubbleDisplayed());
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 ASSERT_FALSE(IsFullscreenPermissionRequested()); 990 ASSERT_FALSE(IsFullscreenPermissionRequested());
1001 ASSERT_NO_FATAL_FAILURE(ToggleTabFullscreenNoRetries(true)); 991 ASSERT_NO_FATAL_FAILURE(ToggleTabFullscreenNoRetries(true));
1002 ASSERT_TRUE(IsFullscreenPermissionRequested()); 992 ASSERT_TRUE(IsFullscreenPermissionRequested());
1003 ASSERT_NO_FATAL_FAILURE(ToggleTabFullscreenNoRetries(false)); 993 ASSERT_NO_FATAL_FAILURE(ToggleTabFullscreenNoRetries(false));
1004 } 994 }
1005 995
1006 INSTANTIATE_TEST_CASE_P( 996 INSTANTIATE_TEST_CASE_P(
1007 ParamaterizedFullscreenControllerInteractiveTestInstance, 997 ParamaterizedFullscreenControllerInteractiveTestInstance,
1008 ParamaterizedFullscreenControllerInteractiveTest, 998 ParamaterizedFullscreenControllerInteractiveTest,
1009 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END)); 999 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698