Reland: Test dismissing CVC prompt for PaymentRequest

Reland: Test dismissing CVC prompt for PaymentRequest

This is an integration test for PaymentRequest that performs the
following steps:
1) Launch PaymentRequest UI.
2) Click "Pay" in PaymentRequest UI.
3) Click "Cancel" in CVC prompt.
4) Click "OK" to dismiss the result dialog.

Originally landed in:
https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e

Consequently reverted in:
https://crrev.com/6982fd4a1d9a76f7a9cd3f3fc8a053a699b1d21a
due to a StrictMode violation from Calendar.getInstance() reading the
/etc/timezone file.

This patch places the timezone reading into an AsyncTask to avoid disk
IO on the UI thread.

BUG=608223
Committed: https://crrev.com/c6238be63b4b82c5442d3d20c3cf6ab8d9acc477
Cr-Commit-Position: refs/heads/master@{#392989}

[please use gerrit instead, 2016-05-11 03:55:57]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-05-11 03:55:58]

dfalcantara@, ptal

I think I've got it!

[gone, 2016-05-11 17:47:46]

Through your reviews, I'm learning so much about how to trigger random
StrictMode violations I didn't know existed.

https://chromiumcodereview.appspot.com/1964323002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
(right):

https://chromiumcodereview.appspot.com/1964323002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:172:
if (mShouldRequestExpirationDate) new CalendarTask().execute();
Do you need to disable the button until the date has been validated?

[please use gerrit instead, 2016-05-11 17:58:56]

On 2016/05/11 17:47:46, dfalcantara wrote:
> Through your reviews, I'm learning so much about how to trigger random
> StrictMode violations I didn't know existed.

A dubious honor :-\

https://chromiumcodereview.appspot.com/1964323002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
(right):

https://chromiumcodereview.appspot.com/1964323002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:172:
if (mShouldRequestExpirationDate) new CalendarTask().execute();
On 2016/05/11 17:47:46, dfalcantara wrote:
> Do you need to disable the button until the date has been validated?

It's disabled on lines 199-200:

  Button verifyButton = mDialog.getButton(AlertDialog.BUTTON_POSITIVE);
  verifyButton.setEnabled(false);

And re-enabled only if the date is valid on lines 274-281:

  @Override
  public void afterTextChanged(Editable s) {
    validate();
  }

  private void validate() {
    mDialog.getButton(AlertDialog.BUTTON_POSITIVE).setEnabled(areInputsValid());
  }

[gone, 2016-05-11 18:00:44]

On 2016/05/11 17:58:56, Rouslan wrote:
> On 2016/05/11 17:47:46, dfalcantara wrote:
> > Through your reviews, I'm learning so much about how to trigger random
> > StrictMode violations I didn't know existed.
> 
> A dubious honor :-\

You should see the ones I was causing that only started crashing on Android N :)

lgtm

[please use gerrit instead, 2016-05-11 18:02:47]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:03:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964323002/1

[commit-bot: I haz the power, 2016-05-11 18:12:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-11 18:14:49]

Description was changed from

==========
Reland: Test dismissing CVC prompt for PaymentRequest

This is an integration test for PaymentRequest that performs the
following steps:
1) Launch PaymentRequest UI.
2) Click "Pay" in PaymentRequest UI.
3) Click "Cancel" in CVC prompt.
4) Click "OK" to dismiss the result dialog.

Originally landed in:
https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e

Consequently reverted in:
https://crrev.com/6982fd4a1d9a76f7a9cd3f3fc8a053a699b1d21a
due to a StrictMode violation from Calendar.getInstance() reading the
/etc/timezone file.

This patch places the timezone reading into an AsyncTask to avoid disk
IO on the UI thread.

BUG=608223
==========

to

==========
Reland: Test dismissing CVC prompt for PaymentRequest

This is an integration test for PaymentRequest that performs the
following steps:
1) Launch PaymentRequest UI.
2) Click "Pay" in PaymentRequest UI.
3) Click "Cancel" in CVC prompt.
4) Click "OK" to dismiss the result dialog.

Originally landed in:
https://crrev.com/e3aede8b82bc67aa19bd567a35a90c058f23cb6e

Consequently reverted in:
https://crrev.com/6982fd4a1d9a76f7a9cd3f3fc8a053a699b1d21a
due to a StrictMode violation from Calendar.getInstance() reading the
/etc/timezone file.

This patch places the timezone reading into an AsyncTask to avoid disk
IO on the UI thread.

BUG=608223

Committed: https://crrev.com/c6238be63b4b82c5442d3d20c3cf6ab8d9acc477
Cr-Commit-Position: refs/heads/master@{#392989}
==========

[commit-bot: I haz the power, 2016-05-11 18:14:50]

Patchset 1 (id:??) landed as
https://crrev.com/c6238be63b4b82c5442d3d20c3cf6ab8d9acc477
Cr-Commit-Position: refs/heads/master@{#392989}