Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 1964303003: UPGRADE: Correctly handle navigations. (Closed)

4 years, 7 months ago by Mike West
4 years, 7 months ago
blink-reviews, chromium-reviews, elawrence,, Nate Chapin,,, Yoav Weiss
Base URL:
Target Ref:


UPGRADE: Correctly handle navigations. The behavior of 'upgrade-insecure-requests' has regressed for iframes and navigations due to some recent changes in those bits of the loader. Of course, I was an idiot, and didn't write layout tests for those pieces, but relied on unit tests. The unit tests kept working, because they hard coded the expected inputs! Hooray! The web, however, broke. Bleh. This patch adjusts things such that iframes and navigations are correctly upgraded in the presence of the directive. As a drive-by, it also disables the mixed content warning that we show for insecure form actions on secure pages if upgrading is active (as part of the UIR promise is that we won't break your security indicators). BUG=610441, 610188 Committed: Cr-Commit-Position: refs/heads/master@{#392890}

Patch Set 1 #

Patch Set 2 : Forms. #


Total messages: 9 (4 generated)
Mike West
Mind taking a look, Jochen? elawrence@: FYI.
4 years, 7 months ago (2016-05-11 08:29:03 UTC) #2
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-11 08:51:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at View timeline at
4 years, 7 months ago (2016-05-11 09:54:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 09:57:13 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 09:59:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
Cr-Commit-Position: refs/heads/master@{#392890}

Powered by Google App Engine
This is Rietveld 408576698