UPGRADE: Correctly handle navigations.

UPGRADE: Correctly handle navigations.

The behavior of 'upgrade-insecure-requests' has regressed for iframes and
navigations due to some recent changes in those bits of the loader. Of
course, I was an idiot, and didn't write layout tests for those pieces,
but relied on unit tests. The unit tests kept working, because they hard
coded the expected inputs! Hooray! The web, however, broke. Bleh.

This patch adjusts things such that iframes and navigations are correctly
upgraded in the presence of the directive.

As a drive-by, it also disables the mixed content warning that we show for
insecure form actions on secure pages if upgrading is active (as part of
the UIR promise is that we won't break your security indicators).

BUG=610441, 610188
Committed: https://crrev.com/06d6974d6903554b04ce7e4eaf7a007ad0455f1e
Cr-Commit-Position: refs/heads/master@{#392890}

[Mike West, 2016-05-11 08:29:02]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2016-05-11 08:29:03]

Mind taking a look, Jochen?

elawrence@: FYI.

[Mike West, 2016-05-11 08:30:12]

Description was changed from

==========
UPGRADE: Correctly handle navigations.

The behavior of 'upgrade-insecure-requests' has regressed for iframes and
navigations due to some recent changes in those bits of the loader. Of
course, I was an idiot, and didn't write layout tests for those pieces,
but relied on unit tests. The unit tests kept working, because they hard
coded the expected inputs! Hooray! The web, however, broke. Bleh.

This patch adjusts things such that iframes and navigations are correctly
upgraded in the presence of the directive.

BUG=610441,610188
==========

to

==========
UPGRADE: Correctly handle navigations.

The behavior of 'upgrade-insecure-requests' has regressed for iframes and
navigations due to some recent changes in those bits of the loader. Of
course, I was an idiot, and didn't write layout tests for those pieces,
but relied on unit tests. The unit tests kept working, because they hard
coded the expected inputs! Hooray! The web, however, broke. Bleh.

This patch adjusts things such that iframes and navigations are correctly
upgraded in the presence of the directive.

As a drive-by, it also disables the mixed content warning that we show for
insecure form actions on secure pages if upgrading is active (as part of
the UIR promise is that we won't break your security indicators).

BUG=610441,610188
==========

[jochen (gone - plz use gerrit), 2016-05-11 08:51:10]

lgtm

[Mike West, 2016-05-11 09:53:54]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-05-11 09:54:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964303003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964303003/20001

[commit-bot: I haz the power, 2016-05-11 09:57:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 09:59:38]

Description was changed from

==========
UPGRADE: Correctly handle navigations.

The behavior of 'upgrade-insecure-requests' has regressed for iframes and
navigations due to some recent changes in those bits of the loader. Of
course, I was an idiot, and didn't write layout tests for those pieces,
but relied on unit tests. The unit tests kept working, because they hard
coded the expected inputs! Hooray! The web, however, broke. Bleh.

This patch adjusts things such that iframes and navigations are correctly
upgraded in the presence of the directive.

As a drive-by, it also disables the mixed content warning that we show for
insecure form actions on secure pages if upgrading is active (as part of
the UIR promise is that we won't break your security indicators).

BUG=610441,610188
==========

to

==========
UPGRADE: Correctly handle navigations.

The behavior of 'upgrade-insecure-requests' has regressed for iframes and
navigations due to some recent changes in those bits of the loader. Of
course, I was an idiot, and didn't write layout tests for those pieces,
but relied on unit tests. The unit tests kept working, because they hard
coded the expected inputs! Hooray! The web, however, broke. Bleh.

This patch adjusts things such that iframes and navigations are correctly
upgraded in the presence of the directive.

As a drive-by, it also disables the mixed content warning that we show for
insecure form actions on secure pages if upgrading is active (as part of
the UIR promise is that we won't break your security indicators).

BUG=610441,610188

Committed: https://crrev.com/06d6974d6903554b04ce7e4eaf7a007ad0455f1e
Cr-Commit-Position: refs/heads/master@{#392890}
==========

[commit-bot: I haz the power, 2016-05-11 09:59:39]

Patchset 2 (id:??) landed as
https://crrev.com/06d6974d6903554b04ce7e4eaf7a007ad0455f1e
Cr-Commit-Position: refs/heads/master@{#392890}