Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor (M51)

Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890
Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
NOPRESUBMIT=true

[qiangchen, 2016-05-10 23:32:47]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
==========

[qiangchen, 2016-05-10 23:32:47]

qiangchen@chromium.org changed reviewers:
+ emircan@chromium.org

[qiangchen, 2016-05-10 23:34:38]

Emircan@: Can you lgtm this merge CL?

[emircan, 2016-05-10 23:47:24]

lgtm

[qiangchen, 2016-05-10 23:48:24]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[qiangchen, 2016-05-10 23:48:27]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2016-05-10 23:49:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964253002/1

[commit-bot: I haz the power, 2016-05-10 23:51:09]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Review-Url: https://codereview.chromium.org/1930003002
Cr-Commit-Position: refs/heads/master@{#390757}
(cherry picked from commit d0a271c39cd8ba5292dd184acd6f7565d1f7348a)

TBR=dalecurtis@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-05-10 23:51:10]

Committed patchset #1 (id:1)