Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890
Committed: https://crrev.com/d0a271c39cd8ba5292dd184acd6f7565d1f7348a
Cr-Commit-Position: refs/heads/master@{#390757}

[qiangchen, 2016-04-28 16:42:01]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

BUG=606890
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer
time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

BUG=606890
==========

[qiangchen, 2016-04-28 16:42:02]

qiangchen@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[qiangchen, 2016-04-28 16:42:14]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer
time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

BUG=606890
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

BUG=606890
==========

[qiangchen, 2016-04-28 16:43:27]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

BUG=606890
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back 
to GetCurrentFrame().

BUG=606890
==========

[qiangchen, 2016-04-28 16:53:04]

Can you take a look at this bug fix?

Thanks.

[qiangchen, 2016-04-28 17:48:41]

qiangchen@chromium.org changed reviewers:
+ emircan@chromium.org

[DaleCurtis, 2016-04-28 17:51:37]

https://codereview.chromium.org/1930003002/diff/1/content/renderer/media/webm...
File content/renderer/media/webmediaplayer_ms_compositor.h (right):

https://codereview.chromium.org/1930003002/diff/1/content/renderer/media/webm...
content/renderer/media/webmediaplayer_ms_compositor.h:86:
scoped_refptr<media::VideoFrame> current_frame();
hacker_style() methods must be inline. Please give this a different name like
GetCurrentFrameAndDontUpdateStatistics() or something similar.

[qiangchen, 2016-04-28 21:02:40]

Done.

https://codereview.chromium.org/1930003002/diff/1/content/renderer/media/webm...
File content/renderer/media/webmediaplayer_ms_compositor.h (right):

https://codereview.chromium.org/1930003002/diff/1/content/renderer/media/webm...
content/renderer/media/webmediaplayer_ms_compositor.h:86:
scoped_refptr<media::VideoFrame> current_frame();
On 2016/04/28 17:51:37, DaleCurtis wrote:
> hacker_style() methods must be inline. Please give this a different name like
> GetCurrentFrameAndDontUpdateStatistics() or something similar.

Done.

[DaleCurtis, 2016-04-28 21:05:53]

lgtm

[qiangchen, 2016-04-29 20:11:55]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2016-04-29 20:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930003002/20001

[commit-bot: I haz the power, 2016-04-29 21:02:46]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back 
to GetCurrentFrame().

BUG=606890
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back 
to GetCurrentFrame().

BUG=606890
==========

[commit-bot: I haz the power, 2016-04-29 21:02:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:28:56]

Patchset 2 (id:??) landed as
https://crrev.com/d0a271c39cd8ba5292dd184acd6f7565d1f7348a
Cr-Commit-Position: refs/heads/master@{#390757}

[commit-bot: I haz the power, 2016-04-30 18:02:35]

Description was changed from

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time 
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make 
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back 
to GetCurrentFrame().

BUG=606890
==========

to

==========
Bug Fix: Rendering stuck due to thread issue of WebMediaPlayerMSCompositor

We observed this when rendering canvas captured frame with alpha
channel. The underlying reason is that it would take a longer time
to process a frame with alpha channel, and thus when PutCurrentFrame()
is called, the |current_frame_| has already been changed, but
we still mark |current_frame_used| to be true, which will make
UpdateCurrentFrame() to return false, and thus chrome compositor
will stop updating.

This CL essentiall moves setting of |current_frame_used| back
to GetCurrentFrame().

BUG=606890

Committed: https://crrev.com/d0a271c39cd8ba5292dd184acd6f7565d1f7348a
Cr-Commit-Position: refs/heads/master@{#390757}
==========