Helper method for non-direct beforeChild in LayoutBlock::addChild().

Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024
Committed: https://crrev.com/cfc78f790b9ad78c5b3575195f6c16295f09f898
Cr-Commit-Position: refs/heads/master@{#393201}

[mstensho (USE GERRIT), 2016-05-11 21:04:53]

Description was changed from

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

BUG=302024
==========

to

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024
==========

[mstensho (USE GERRIT), 2016-05-11 21:06:00]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org, wkorman@chromium.org

[mstensho (USE GERRIT), 2016-05-11 21:06:00]

ptal

https://codereview.chromium.org/1964203004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/1964203004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:390:
RELEASE_ASSERT(beforeDescendantContainer->isAnonymous());
Here's a difference. We previously allowed this situation. addChild() would just
happily go on with a |this| and |beforeChild| that didn't have a direct
parent/child relationship, which is just scary.

This assertion caught a mistake in one of the unit tests (it wanted to insert a
DOM child into a DOM parent before a DOM grandchild of said parent), which is
also fixed in this CL.

[eae, 2016-05-11 21:10:12]

LGTM

https://codereview.chromium.org/1964203004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/1964203004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:390:
RELEASE_ASSERT(beforeDescendantContainer->isAnonymous());
On 2016/05/11 21:06:00, mstensho wrote:
> Here's a difference. We previously allowed this situation. addChild() would
just
> happily go on with a |this| and |beforeChild| that didn't have a direct
> parent/child relationship, which is just scary.
> 
> This assertion caught a mistake in one of the unit tests (it wanted to insert
a
> DOM child into a DOM parent before a DOM grandchild of said parent), which is
> also fixed in this CL.

Yay!

[eae, 2016-05-11 21:10:26]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-05-11 21:11:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964203004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964203004/20001

[commit-bot: I haz the power, 2016-05-11 23:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 23:32:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mstensho (USE GERRIT), 2016-05-12 05:12:52]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-05-12 05:13:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1964203004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1964203004/20001

[commit-bot: I haz the power, 2016-05-12 07:38:55]

Description was changed from

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024
==========

to

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024
==========

[commit-bot: I haz the power, 2016-05-12 07:38:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 07:41:13]

Description was changed from

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024
==========

to

==========
Helper method for non-direct beforeChild in LayoutBlock::addChild().

A lot of what's in LayoutBlock::addChild() will eventually be moved down to
LayoutBlockFlow::addChild(), but both classes are expected to handle insertion
of children before a non-direct beforeChild.

One difference, compared to how it used to work when all of this was inside
addChild(), is that it's no longer allowed to continue if we fail to find a
suitable direct beforeChild replacement. Will always RELEASE_ASSERT() in such
situations now.

BUG=302024

Committed: https://crrev.com/cfc78f790b9ad78c5b3575195f6c16295f09f898
Cr-Commit-Position: refs/heads/master@{#393201}
==========

[commit-bot: I haz the power, 2016-05-12 07:41:14]

Patchset 2 (id:??) landed as
https://crrev.com/cfc78f790b9ad78c5b3575195f6c16295f09f898
Cr-Commit-Position: refs/heads/master@{#393201}