Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp

Issue 1964203004: Helper method for non-direct beforeChild in LayoutBlock::addChild(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix broken test. Use RELEASE_ASSERT. Back out unnecessary change. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp
index dda940e7d5cb07a18636765d06d4a2431d2cb515..5c70b6fec23fc96c59ab29de28af3c71c59a04c4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp
@@ -657,9 +657,9 @@ TEST_F(MultiColumnTreeModifyingTest, InsertSubtreeWithSpannerBeforeContentAndRem
TEST_F(MultiColumnTreeModifyingTest, InsertSubtreeWithSpannerInsideContentAndRemove)
{
- setMulticolHTML("<div id='block'>text<div class='s'></div>text</div><div id='mc'><div>outside<div id='insertBefore'>outside</div></div></div>");
+ setMulticolHTML("<div id='block'>text<div class='s'></div>text</div><div id='mc'><div id='newParent'>outside<div id='insertBefore'>outside</div></div></div>");
EXPECT_EQ(columnSetSignature("mc"), "c");
- reparentLayoutObject("mc", "block", "insertBefore");
+ reparentLayoutObject("newParent", "block", "insertBefore");
EXPECT_EQ(columnSetSignature("mc"), "csc");
destroyLayoutObject("block");
EXPECT_EQ(columnSetSignature("mc"), "c");

Powered by Google App Engine
This is Rietveld 408576698