Dart: Refactors Proxies

Dart: Refactors Proxies

This change implements some of the good suggestions from:

https://github.com/domokit/mojo/issues/647

In particular, it does away with the wierd 'ptr' thing, is more
careful to mangle names that could conflict, and hopefully has
an easier-to-follow structure. This comes at the cost of needing
an indirection to access "control" functions on a Proxy, as
suggested by floitsch@ (though I have punched holes for close()
and responseOrError() since they show up a lot).

related #647

R=johnmccutchan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/c200560ac45a79b61b8e8c0444af471789f5669f

[zra, 2016-05-11 15:56:47]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-05-12 17:24:27]

My one big concern is that this is a major API breakage that might cause a bunch
of teams pain. If we're going to break the API in various ways, maybe we should
batch the changes up so external teams only have to port once.

https://codereview.chromium.org/1964193002/diff/10001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/proxy.dart (right):

https://codereview.chromium.org/1964193002/diff/10001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/proxy.dart:36: Future close({bool immediate:
false}) => ctrl.close(immediate: immediate);
Could 'close' and 'responseOrError' be dropped from Proxy and callers juts call
through ctrl? That would mean fewer reserved names.

https://codereview.chromium.org/1964193002/diff/10001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_dart_generator.py (right):

https://codereview.chromium.org/1964193002/diff/10001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_dart_generator.py:74: "close",
how are these mangled? Never mind, found in other file, "word" -> "word_"

[zra, 2016-05-12 18:22:42]

It's likely that the changes won't hit users until they are pushed to the
published mojo package. So we can land the CLs bit-by-bit and then push them to
the mojo package all-at-once.

https://codereview.chromium.org/1964193002/diff/10001/mojo/dart/packages/mojo...
File mojo/dart/packages/mojo/lib/src/proxy.dart (right):

https://codereview.chromium.org/1964193002/diff/10001/mojo/dart/packages/mojo...
mojo/dart/packages/mojo/lib/src/proxy.dart:36: Future close({bool immediate:
false}) => ctrl.close(immediate: immediate);
On 2016/05/12 17:24:27, Cutch wrote:
> Could 'close' and 'responseOrError' be dropped from Proxy and callers juts
call
> through ctrl? That would mean fewer reserved names.

Yes, however porting would be more difficult since currently close() and
responseOrError() are accessed directly from the generated Proxy object.

https://codereview.chromium.org/1964193002/diff/10001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_dart_generator.py (right):

https://codereview.chromium.org/1964193002/diff/10001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_dart_generator.py:74: "close",
On 2016/05/12 17:24:27, Cutch wrote:
> how are these mangled? Never mind, found in other file, "word" -> "word_"

Expanded comment.

[Cutch, 2016-05-12 21:53:24]

LGTM after discussions in person about how to minimize developer pain.

[zra, 2016-05-13 15:04:20]

Description was changed from

==========
Dart: Refactors Proxies

This change implements some of the good suggestions from:

https://github.com/domokit/mojo/issues/647

In particular, it does away with the wierd 'ptr' thing, is more
careful to mangle names that could conflict, and hopefully has
an easier-to-follow structure. This comes at the cost of needing
an indirection to access "control" functions on a Proxy, as
suggested by floitsch@ (though I have punched holes for close()
and responseOrError() since they show up a lot).

related #647
==========

to

==========
Dart: Refactors Proxies

This change implements some of the good suggestions from:

https://github.com/domokit/mojo/issues/647

In particular, it does away with the wierd 'ptr' thing, is more
careful to mangle names that could conflict, and hopefully has
an easier-to-follow structure. This comes at the cost of needing
an indirection to access "control" functions on a Proxy, as
suggested by floitsch@ (though I have punched holes for close()
and responseOrError() since they show up a lot).

related #647

R=johnmccutchan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/c200560ac45a79b61b8e8c0444a...
==========

[zra, 2016-05-13 15:04:22]

Committed patchset #3 (id:20001) manually as
c200560ac45a79b61b8e8c0444af471789f5669f (presubmit successful).