Dart: Refactors Proxies

mojo/dart/packages/mojo_services/lib/mojo/cookie_store.mojom.dart

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 library cookie_store_mojom;
 import 'dart:async';
 import 'package:mojo/bindings.dart' as bindings;
 import 'package:mojo/core.dart' as core;
 import 'package:mojo/mojo/bindings/types/service_describer.mojom.dart' as service_describer;
 
@@ skipping 314 matching lines @@
       responseFactory(null);
 }
 
 abstract class CookieStore {
   static const String serviceName = null;
   dynamic get(String url,[Function responseFactory = null]);
   dynamic set(String url,String cookie,[Function responseFactory = null]);
 }
 
 
-class _CookieStoreProxyImpl extends bindings.Proxy {
-  _CookieStoreProxyImpl.fromEndpoint(
+class _CookieStoreProxyControl extends bindings.ProxyMessageHandler
+                                      implements bindings.ProxyControl {
+  _CookieStoreProxyControl.fromEndpoint(
       core.MojoMessagePipeEndpoint endpoint) : super.fromEndpoint(endpoint);
 
-  _CookieStoreProxyImpl.fromHandle(core.MojoHandle handle) :
-      super.fromHandle(handle);
+  _CookieStoreProxyControl.fromHandle(
+      core.MojoHandle handle) : super.fromHandle(handle);
 
-  _CookieStoreProxyImpl.unbound() : super.unbound();
-
-  static _CookieStoreProxyImpl newFromEndpoint(
-      core.MojoMessagePipeEndpoint endpoint) {
-    assert(endpoint.setDescription("For _CookieStoreProxyImpl"));
-    return new _CookieStoreProxyImpl.fromEndpoint(endpoint);
-  }
+  _CookieStoreProxyControl.unbound() : super.unbound();
 
   service_describer.ServiceDescription get serviceDescription =>
-    new _CookieStoreServiceDescription();
+      new _CookieStoreServiceDescription();
 
+  String get serviceName => CookieStore.serviceName;
+
+  @override
   void handleResponse(bindings.ServiceMessage message) {
     switch (message.header.type) {
       case _cookieStoreMethodGetName:
         var r = CookieStoreGetResponseParams.deserialize(
             message.payload);
         if (!message.header.hasRequestId) {
           proxyError("Expected a message with a valid request Id.");
           return;
         }
         Completer c = completerMap[message.header.requestId];
@@ skipping 29 matching lines @@
         }
         c.complete(r);
         break;
       default:
         proxyError("Unexpected message type: ${message.header.type}");
         close(immediate: true);
         break;
     }
   }
 
+  @override
   String toString() {
     var superString = super.toString();
-    return "_CookieStoreProxyImpl($superString)";
+    return "_CookieStoreProxyControl($superString)";
   }
 }
 
 
-class _CookieStoreProxyCalls implements CookieStore {
-  _CookieStoreProxyImpl _proxyImpl;
+class CookieStoreProxy extends bindings.Proxy
+                              implements CookieStore {
+  CookieStoreProxy.fromEndpoint(
+      core.MojoMessagePipeEndpoint endpoint)
+      : super(new _CookieStoreProxyControl.fromEndpoint(endpoint));
 
-  _CookieStoreProxyCalls(this._proxyImpl);
-    dynamic get(String url,[Function responseFactory = null]) {
-      var params = new _CookieStoreGetParams();
-      params.url = url;
-      return _proxyImpl.sendMessageWithRequestId(
-          params,
-          _cookieStoreMethodGetName,
-          -1,
-          bindings.MessageHeader.kMessageExpectsResponse);
-    }
-    dynamic set(String url,String cookie,[Function responseFactory = null]) {
-      var params = new _CookieStoreSetParams();
-      params.url = url;
-      params.cookie = cookie;
-      return _proxyImpl.sendMessageWithRequestId(
-          params,
-          _cookieStoreMethodSetName,
-          -1,
-          bindings.MessageHeader.kMessageExpectsResponse);
-    }
-}
+  CookieStoreProxy.fromHandle(core.MojoHandle handle)
+      : super(new _CookieStoreProxyControl.fromHandle(handle));
 
+  CookieStoreProxy.unbound()
+      : super(new _CookieStoreProxyControl.unbound());
 
-class CookieStoreProxy implements bindings.ProxyBase {
-  final bindings.Proxy impl;
-  CookieStore ptr;
-
-  CookieStoreProxy(_CookieStoreProxyImpl proxyImpl) :
-      impl = proxyImpl,
-      ptr = new _CookieStoreProxyCalls(proxyImpl);
-
-  CookieStoreProxy.fromEndpoint(
-      core.MojoMessagePipeEndpoint endpoint) :
-      impl = new _CookieStoreProxyImpl.fromEndpoint(endpoint) {
-    ptr = new _CookieStoreProxyCalls(impl);
-  }
-
-  CookieStoreProxy.fromHandle(core.MojoHandle handle) :
-      impl = new _CookieStoreProxyImpl.fromHandle(handle) {
-    ptr = new _CookieStoreProxyCalls(impl);
-  }
-
-  CookieStoreProxy.unbound() :
-      impl = new _CookieStoreProxyImpl.unbound() {
-    ptr = new _CookieStoreProxyCalls(impl);
+  static CookieStoreProxy newFromEndpoint(
+      core.MojoMessagePipeEndpoint endpoint) {
+    assert(endpoint.setDescription("For CookieStoreProxy"));
+    return new CookieStoreProxy.fromEndpoint(endpoint);
   }
 
   factory CookieStoreProxy.connectToService(
       bindings.ServiceConnector s, String url, [String serviceName]) {
     CookieStoreProxy p = new CookieStoreProxy.unbound();
     s.connectToService(url, p, serviceName);
     return p;
   }
 
-  static CookieStoreProxy newFromEndpoint(
-      core.MojoMessagePipeEndpoint endpoint) {
-    assert(endpoint.setDescription("For CookieStoreProxy"));
-    return new CookieStoreProxy.fromEndpoint(endpoint);
+
+  dynamic get(String url,[Function responseFactory = null]) {
+    var params = new _CookieStoreGetParams();
+    params.url = url;
+    return ctrl.sendMessageWithRequestId(
+        params,
+        _cookieStoreMethodGetName,
+        -1,
+        bindings.MessageHeader.kMessageExpectsResponse);
   }
-
-  String get serviceName => CookieStore.serviceName;
-
-  Future close({bool immediate: false}) => impl.close(immediate: immediate);
-
-  Future responseOrError(Future f) => impl.responseOrError(f);
-
-  Future get errorFuture => impl.errorFuture;
-
-  int get version => impl.version;
-
-  Future<int> queryVersion() => impl.queryVersion();
-
-  void requireVersion(int requiredVersion) {
-    impl.requireVersion(requiredVersion);
-  }
-
-  String toString() {
-    return "CookieStoreProxy($impl)";
+  dynamic set(String url,String cookie,[Function responseFactory = null]) {
+    var params = new _CookieStoreSetParams();
+    params.url = url;
+    params.cookie = cookie;
+    return ctrl.sendMessageWithRequestId(
+        params,
+        _cookieStoreMethodSetName,
+        -1,
+        bindings.MessageHeader.kMessageExpectsResponse);
   }
 }
 
 
 class CookieStoreStub extends bindings.Stub {
   CookieStore _impl;
 
   CookieStoreStub.fromEndpoint(
       core.MojoMessagePipeEndpoint endpoint, [CookieStore impl])
       : super.fromEndpoint(endpoint, autoBegin: impl != null) {
@@ skipping 117 matching lines @@
   static service_describer.ServiceDescription get serviceDescription {
     if (_cachedServiceDescription == null) {
       _cachedServiceDescription = new _CookieStoreServiceDescription();
     }
     return _cachedServiceDescription;
   }
 }