Issue 196413004: Revert of Value sanitization for input[type=text] should not truncate a value at control character

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196413004: Revert of Value sanitization for input[type=text] should not truncate a value at control character (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
keishi, Habib Virji

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@bug196640

Visibility:
Public.

Revert of Value sanitization for input[type=text] should not truncate a value at control character (https://codereview.chromium.org/189843008/) Reason for revert: Wrong CL description. Original issue's description: > The new behavior is compatible with IE and Firefox. > > R=tkent, keishi1 > BUG=261846 > TEST=Test string containing control character is not truncated > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168986 TBR=keishi@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=261846 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168988

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -21 lines)			Patch
M	LayoutTests/fast/forms/input-value-sanitization.html	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	LayoutTests/fast/forms/input-value-sanitization-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/forms/paste-multiline-text-input.html	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/html/forms/TextFieldInputType.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Value sanitization for input[type=text] should not truncate a value at control character

6 years, 9 months ago (2014-03-12 06:54:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/196413004/1

6 years, 9 months ago (2014-03-12 06:54:46 UTC) #2

Message was sent while issue was closed.

Change committed as 168988