Support vulkan surface formats for Android.

Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/02f1686c0cf4cf374c2e750eb8e728f2bb4f189a
Cr-Commit-Position: refs/heads/master@{#393417}

[sohanjg, 2016-05-10 11:47:58]

Description was changed from

==========
Support vulkan surface formats for Android.

BUG=582558
==========

to

==========
Support vulkan surface formats for Android.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sohanjg, 2016-05-10 11:52:17]

sohan.jyoti@samsung.com changed reviewers:
+ dyen@chromium.org, piman@chromium.org

[sohanjg, 2016-05-10 11:52:18]

Can you please take a look, if this is what we want. Thanks.

[piman, 2016-05-10 19:52:44]

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.cc
File gpu/vulkan/vulkan_surface.cc (right):

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.c...
gpu/vulkan/vulkan_surface.cc:99: const VkFormat preferred_format =
kNativeVkFormat[format];
nit: this is not used anymore, please remove.

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.c...
gpu/vulkan/vulkan_surface.cc:107: }
I think we could instead have 2 arrays, kPreferredVkFormats32 (with
VK_FORMAT_B8G8R8A8_UNORM and VK_FORMAT_R8G8B8A8_UNORM) and kPreferredVkFormats16
(with VK_FORMAT_R5G6B5_UNORM_PACK16), and we could pick here:
const VkFormat* preferred_formats = (format == FORMAT_RGBA_32) ?
kPreferredVkFormats32 : kPreferredVkFormats16;

[sohanjg, 2016-05-11 09:25:50]

Please take a look, thanks.

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.cc
File gpu/vulkan/vulkan_surface.cc (right):

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.c...
gpu/vulkan/vulkan_surface.cc:99: const VkFormat preferred_format =
kNativeVkFormat[format];
On 2016/05/10 19:52:44, piman wrote:
> nit: this is not used anymore, please remove.

Acknowledged.

https://codereview.chromium.org/1963983002/diff/1/gpu/vulkan/vulkan_surface.c...
gpu/vulkan/vulkan_surface.cc:107: }
On 2016/05/10 19:52:44, piman wrote:
> I think we could instead have 2 arrays, kPreferredVkFormats32 (with
> VK_FORMAT_B8G8R8A8_UNORM and VK_FORMAT_R8G8B8A8_UNORM) and
kPreferredVkFormats16
> (with VK_FORMAT_R5G6B5_UNORM_PACK16), and we could pick here:
> const VkFormat* preferred_formats = (format == FORMAT_RGBA_32) ?
> kPreferredVkFormats32 : kPreferredVkFormats16;

Done.

[piman, 2016-05-11 17:11:57]

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
File gpu/vulkan/vulkan_surface.cc (right):

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:23: const VkFormat kNativeVkFormat[] = {
This is not used anymore, please remove.

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:119: uint counter = 0;
nit: uint->unsigned int

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:120: uint size = (format == FORMAT_RGBA_32)
nit: uint->unsigned int. This can be hoisted out of the loop (next to the
preferred_formats definition)

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:124: if (supported_format.format ==
*(preferred_formats + counter)) {
nit: *(preferred_formats + counter) -> preferred_formats[counter]

[sohanjg, 2016-05-12 06:34:31]

Please take a look, thanks.

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
File gpu/vulkan/vulkan_surface.cc (right):

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:23: const VkFormat kNativeVkFormat[] = {
On 2016/05/11 17:11:56, piman wrote:
> This is not used anymore, please remove.

Done.

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:119: uint counter = 0;
On 2016/05/11 17:11:56, piman wrote:
> nit: uint->unsigned int

Done.

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:120: uint size = (format == FORMAT_RGBA_32)
On 2016/05/11 17:11:56, piman wrote:
> nit: uint->unsigned int. This can be hoisted out of the loop (next to the
> preferred_formats definition)

Done.

https://codereview.chromium.org/1963983002/diff/20001/gpu/vulkan/vulkan_surfa...
gpu/vulkan/vulkan_surface.cc:124: if (supported_format.format ==
*(preferred_formats + counter)) {
On 2016/05/11 17:11:56, piman wrote:
> nit: *(preferred_formats + counter) -> preferred_formats[counter]

Done.

[sohanjg, 2016-05-12 10:32:41]

Description was changed from

==========
Support vulkan surface formats for Android.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-05-12 22:14:12]

lgtm

[sohanjg, 2016-05-13 00:45:04]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2016-05-13 00:45:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963983002/40001

[commit-bot: I haz the power, 2016-05-13 01:18:41]

Description was changed from

==========
Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-05-13 01:18:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 01:20:14]

Description was changed from

==========
Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support vulkan surface formats for Android.

This extends the Vulkan surface formats to include VK_FORMAT_R8G8B8A8_UNORM
as an additional preferred RGBA 32 format.

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/02f1686c0cf4cf374c2e750eb8e728f2bb4f189a
Cr-Commit-Position: refs/heads/master@{#393417}
==========

[commit-bot: I haz the power, 2016-05-13 01:20:15]

Patchset 3 (id:??) landed as
https://crrev.com/02f1686c0cf4cf374c2e750eb8e728f2bb4f189a
Cr-Commit-Position: refs/heads/master@{#393417}