Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: gpu/vulkan/vulkan_surface.cc

Issue 1963983002: Support vulkan surface formats for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/vulkan/vulkan_surface.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/vulkan/vulkan_surface.h" 5 #include "gpu/vulkan/vulkan_surface.h"
6 6
7 #include <vulkan/vulkan.h> 7 #include <vulkan/vulkan.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "gpu/vulkan/vulkan_command_buffer.h" 10 #include "gpu/vulkan/vulkan_command_buffer.h"
11 #include "gpu/vulkan/vulkan_device_queue.h" 11 #include "gpu/vulkan/vulkan_device_queue.h"
12 #include "gpu/vulkan/vulkan_implementation.h" 12 #include "gpu/vulkan/vulkan_implementation.h"
13 #include "gpu/vulkan/vulkan_platform.h" 13 #include "gpu/vulkan/vulkan_platform.h"
14 #include "gpu/vulkan/vulkan_swap_chain.h" 14 #include "gpu/vulkan/vulkan_swap_chain.h"
15 15
16 #if defined(USE_X11) 16 #if defined(USE_X11)
17 #include "ui/gfx/x/x11_types.h" 17 #include "ui/gfx/x/x11_types.h"
18 #endif // defined(USE_X11) 18 #endif // defined(USE_X11)
19 19
20 namespace gpu { 20 namespace gpu {
21 21
22 namespace { 22 namespace {
23 const VkFormat kNativeVkFormat[] = { 23 const VkFormat kPreferredVkFormats32[] = {
24 VK_FORMAT_B8G8R8A8_UNORM, // FORMAT_BGRA8888, 24 VK_FORMAT_B8G8R8A8_UNORM, // FORMAT_BGRA8888,
25 VK_FORMAT_R8G8B8A8_UNORM, // FORMAT_RGBA8888,
26 };
27
28 const VkFormat kPreferredVkFormats16[] = {
25 VK_FORMAT_R5G6B5_UNORM_PACK16, // FORMAT_RGB565, 29 VK_FORMAT_R5G6B5_UNORM_PACK16, // FORMAT_RGB565,
26 }; 30 };
27 static_assert(arraysize(kNativeVkFormat) == VulkanSurface::NUM_SURFACE_FORMATS,
28 "Array size for kNativeVkFormat must match surface formats.");
29 31
30 } // namespace 32 } // namespace
31 33
32 class VulkanWSISurface : public VulkanSurface { 34 class VulkanWSISurface : public VulkanSurface {
33 public: 35 public:
34 explicit VulkanWSISurface(gfx::AcceleratedWidget window) : window_(window) {} 36 explicit VulkanWSISurface(gfx::AcceleratedWidget window) : window_(window) {}
35 37
36 ~VulkanWSISurface() override { 38 ~VulkanWSISurface() override {
37 DCHECK_EQ(static_cast<VkSurfaceKHR>(VK_NULL_HANDLE), surface_); 39 DCHECK_EQ(static_cast<VkSurfaceKHR>(VK_NULL_HANDLE), surface_);
38 } 40 }
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 std::vector<VkSurfaceFormatKHR> formats(format_count); 89 std::vector<VkSurfaceFormatKHR> formats(format_count);
88 result = vkGetPhysicalDeviceSurfaceFormatsKHR( 90 result = vkGetPhysicalDeviceSurfaceFormatsKHR(
89 device_queue_->GetVulkanPhysicalDevice(), surface_, &format_count, 91 device_queue_->GetVulkanPhysicalDevice(), surface_, &format_count,
90 formats.data()); 92 formats.data());
91 if (VK_SUCCESS != result) { 93 if (VK_SUCCESS != result) {
92 DLOG(ERROR) << "vkGetPhysicalDeviceSurfaceFormatsKHR() failed: " 94 DLOG(ERROR) << "vkGetPhysicalDeviceSurfaceFormatsKHR() failed: "
93 << result; 95 << result;
94 return false; 96 return false;
95 } 97 }
96 98
97 const VkFormat preferred_format = kNativeVkFormat[format]; 99 const VkFormat* preferred_formats = (format == FORMAT_RGBA_32)
100 ? kPreferredVkFormats32
101 : kPreferredVkFormats16;
102 unsigned int size = (format == FORMAT_RGBA_32)
103 ? arraysize(kPreferredVkFormats32)
104 : arraysize(kPreferredVkFormats16);
105
98 if (formats.size() == 1 && VK_FORMAT_UNDEFINED == formats[0].format) { 106 if (formats.size() == 1 && VK_FORMAT_UNDEFINED == formats[0].format) {
99 surface_format_.format = preferred_format; 107 surface_format_.format = preferred_formats[0];
100 surface_format_.colorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR; 108 surface_format_.colorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR;
101 } else { 109 } else {
102 bool format_set = false; 110 bool format_set = false;
103 for (VkSurfaceFormatKHR supported_format : formats) { 111 for (VkSurfaceFormatKHR supported_format : formats) {
104 if (supported_format.format == preferred_format) { 112 unsigned int counter = 0;
105 surface_format_ = supported_format; 113 while (counter < size && format_set == false) {
106 surface_format_.colorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR; 114 if (supported_format.format == preferred_formats[counter]) {
107 format_set = true; 115 surface_format_ = supported_format;
116 surface_format_.colorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR;
117 format_set = true;
118 }
119 counter++;
120 }
121 if (format_set)
108 break; 122 break;
109 }
110 } 123 }
111 if (!format_set) { 124 if (!format_set) {
112 DLOG(ERROR) << "Format not supported."; 125 DLOG(ERROR) << "Format not supported.";
113 return false; 126 return false;
114 } 127 }
115 } 128 }
116 129
117 // Get Surface Information. 130 // Get Surface Information.
118 VkSurfaceCapabilitiesKHR surface_caps; 131 VkSurfaceCapabilitiesKHR surface_caps;
119 result = vkGetPhysicalDeviceSurfaceCapabilitiesKHR( 132 result = vkGetPhysicalDeviceSurfaceCapabilitiesKHR(
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 175
163 // static 176 // static
164 std::unique_ptr<VulkanSurface> VulkanSurface::CreateViewSurface( 177 std::unique_ptr<VulkanSurface> VulkanSurface::CreateViewSurface(
165 gfx::AcceleratedWidget window) { 178 gfx::AcceleratedWidget window) {
166 return std::unique_ptr<VulkanSurface>(new VulkanWSISurface(window)); 179 return std::unique_ptr<VulkanSurface>(new VulkanWSISurface(window));
167 } 180 }
168 181
169 VulkanSurface::VulkanSurface() {} 182 VulkanSurface::VulkanSurface() {}
170 183
171 } // namespace gpu 184 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/vulkan/vulkan_surface.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698