Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1963973003: [runtime] Deprecate Runtime_FinalizeClassDefinition entry. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-enable-eval
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate Runtime_FinalizeClassDefinition entry. By now the runtime entry function in question is a duplicate of the existing Runtime_ToFastProperties function. This just gets rid of the duplication. R=bmeurer@chromium.org Committed: https://crrev.com/3cc12b4a96d898be69470ed29d7743e79eab1774 Cr-Commit-Position: refs/heads/master@{#36161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-10 13:16:39 UTC) #3
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-10 18:41:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963973003/1
4 years, 7 months ago (2016-05-11 08:29:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:31:09 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:31:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc12b4a96d898be69470ed29d7743e79eab1774
Cr-Commit-Position: refs/heads/master@{#36161}

Powered by Google App Engine
This is Rietveld 408576698