Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(681)

Issue 1962103003: [turbofan] Enable optimization of top-level eval code. (Closed)

Created:
3 years, 9 months ago by Michael Starzinger
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable optimization of top-level eval code. This removes the explicit disabling of optimization for eval code. Such code can by now be optimized by TurboFan. Note that the usual heuristics in the AstNumberingVisitor still apply and will be used to choose the effective optimization backend. R=bmeurer@chromium.org Committed: https://crrev.com/0cb89c2677ac6668f5d5c03c72ac2decd618ddff Cr-Commit-Position: refs/heads/master@{#36156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
3 years, 9 months ago (2016-05-10 11:40:50 UTC) #3
Benedikt Meurer
lgtm
3 years, 9 months ago (2016-05-10 18:42:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962103003/1
3 years, 9 months ago (2016-05-11 07:14:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 9 months ago (2016-05-11 07:16:24 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2016-05-11 07:16:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cb89c2677ac6668f5d5c03c72ac2decd618ddff
Cr-Commit-Position: refs/heads/master@{#36156}

Powered by Google App Engine
This is Rietveld 408576698