Refactor CancelableTaskManager to use std::map.

Refactor CancelableTaskManager to use std::map.

BUG=

Committed: https://crrev.com/f2d649a04b5eff397a7b598848f7ee7292ccda52
Cr-Commit-Position: refs/heads/master@{#36142}

[ulan, 2016-05-10 12:12:16]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-05-10 12:12:16]

ptal

[Michael Lippautz, 2016-05-10 12:18:22]

lgtm, thanks a lot!

[ulan, 2016-05-10 12:20:15]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-05-10 12:20:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963853004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963853004/1

[ulan, 2016-05-10 12:20:46]

The CQ bit was unchecked by ulan@chromium.org

[ulan, 2016-05-10 12:26:28]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-05-10 12:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1963853004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-10 12:26:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963853004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963853004/20001

[commit-bot: I haz the power, 2016-05-10 12:59:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 12:59:29]

Description was changed from

==========
Refactor CancelableTaskManager to use std::map.

BUG=
==========

to

==========
Refactor CancelableTaskManager to use std::map.

BUG=

Committed: https://crrev.com/f2d649a04b5eff397a7b598848f7ee7292ccda52
Cr-Commit-Position: refs/heads/master@{#36142}
==========

[commit-bot: I haz the power, 2016-05-10 12:59:30]

Patchset 2 (id:??) landed as
https://crrev.com/f2d649a04b5eff397a7b598848f7ee7292ccda52
Cr-Commit-Position: refs/heads/master@{#36142}

[Nico, 2016-05-11 13:04:23]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-11 13:04:24]

https://codereview.chromium.org/1963853004/diff/20001/src/cancelable-task.h
File src/cancelable-task.h (right):

https://codereview.chromium.org/1963853004/diff/20001/src/cancelable-task.h#n...
src/cancelable-task.h:55: std::map<uint32_t, Cancelable*> cancelable_tasks_;
(if you don't need to ordering -- and given this was a HashMap before you might
not need it -- you could use std::unordered_map as well)

[ulan, 2016-05-11 16:56:28]

On 2016/05/11 13:04:24, Nico wrote:
> https://codereview.chromium.org/1963853004/diff/20001/src/cancelable-task.h
> File src/cancelable-task.h (right):
> 
>
https://codereview.chromium.org/1963853004/diff/20001/src/cancelable-task.h#n...
> src/cancelable-task.h:55: std::map<uint32_t, Cancelable*> cancelable_tasks_;
> (if you don't need to ordering -- and given this was a HashMap before you
might
> not need it -- you could use std::unordered_map as well)

Thanks for the tip, Nico. I agree that unordered_map would fit better here.
I'll check with the team if we can start using unordered_map in V8.