Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/cancelable-task.h

Issue 1963853004: Refactor CancelableTaskManager to use std::map. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/cancelable-task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cancelable-task.h
diff --git a/src/cancelable-task.h b/src/cancelable-task.h
index a8387fcd950008e0b416e4cb09c6477a14334147..6c1b631d8d7e1b6dbbaa8cede2bd0257004a5362 100644
--- a/src/cancelable-task.h
+++ b/src/cancelable-task.h
@@ -5,11 +5,12 @@
#ifndef V8_CANCELABLE_TASK_H_
#define V8_CANCELABLE_TASK_H_
+#include <map>
+
#include "include/v8-platform.h"
#include "src/atomic-utils.h"
#include "src/base/macros.h"
#include "src/base/platform/condition-variable.h"
-#include "src/hashmap.h"
namespace v8 {
namespace internal {
@@ -51,7 +52,7 @@ class CancelableTaskManager {
uint32_t task_id_counter_;
// A set of cancelable tasks that are currently registered.
- HashMap cancelable_tasks_;
+ std::map<uint32_t, Cancelable*> cancelable_tasks_;
Nico 2016/05/11 13:04:24 (if you don't need to ordering -- and given this w
// Mutex and condition variable enabling concurrent register and removing, as
// well as waiting for background tasks on {CancelAndWait}.
« no previous file with comments | « no previous file | src/cancelable-task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698