Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1963823003: Rewrite Share interface docs and split into two APIs. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
benwells
CC:
Sam McNally, chrome-apps-syd-reviews_chromium.org
Base URL:
git@github.com:chromium/ballista.git@master
Target Ref:
refs/heads/master
Project:
ballista
Visibility:
Public.

Description

Rewrite Share interface docs and split into two APIs. This changes the API surface from generic actions to a specific share-only API called Web Share, and a follow-up proposal called Web Share Target. The idea is to partition the Ballista project into specialized interfaces that can be independently standardized. R=benwells@chromium.org Committed: https://github.com/chromium/ballista/blob/master4a66ebdc86d321cb916f25bd447a206eb2477e23

Patch Set 1 #

Patch Set 2 : Minor. #

Patch Set 3 : Share target, explainer and more work on share. #

Patch Set 4 : Update date. #

Patch Set 5 : Rebrand as Web Share (not Ballista). #

Total comments: 11

Patch Set 6 : Respond to benwells review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -264 lines) Patch
M docs/explainer.md View 1 2 2 chunks +7 lines, -13 lines 0 comments Download
M docs/interface_share.md View 1 2 3 4 5 1 chunk +75 lines, -251 lines 0 comments Download
A docs/interface_share_target.md View 1 2 3 4 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Matt Giuca
Ben, PTAL. Probably easier to just read the updated formatted documents: https://github.com/mgiuca/ballista/blob/share-only-api/docs/interface_share.md https://github.com/mgiuca/ballista/blob/share-only-api/docs/interface_share_target.md https://github.com/mgiuca/ballista/blob/share-only-api/docs/explainer.md
4 years, 6 months ago (2016-05-30 03:05:56 UTC) #4
benwells
https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md File docs/interface_share.md (right): https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md#newcode7 docs/interface_share.md:7: for a website to receive share requests; only native ...
4 years, 6 months ago (2016-06-01 00:48:33 UTC) #5
Matt Giuca
https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md File docs/interface_share.md (right): https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md#newcode7 docs/interface_share.md:7: for a website to receive share requests; only native ...
4 years, 6 months ago (2016-06-01 01:01:14 UTC) #6
benwells
https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md File docs/interface_share.md (right): https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md#newcode13 docs/interface_share.md:13: [explainer document](explainer.md). On 2016/06/01 01:01:13, Matt Giuca wrote: > ...
4 years, 6 months ago (2016-06-01 01:28:11 UTC) #7
Matt Giuca
https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md File docs/interface_share.md (right): https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md#newcode13 docs/interface_share.md:13: [explainer document](explainer.md). On 2016/06/01 01:28:11, benwells wrote: > On ...
4 years, 6 months ago (2016-06-01 01:31:57 UTC) #8
benwells
lgtm https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md File docs/interface_share.md (right): https://codereview.chromium.org/1963823003/diff/60002/docs/interface_share.md#newcode13 docs/interface_share.md:13: [explainer document](explainer.md). On 2016/06/01 01:31:57, Matt Giuca wrote: ...
4 years, 6 months ago (2016-06-01 01:47:54 UTC) #9
Matt Giuca
4 years, 6 months ago (2016-06-03 05:11:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:90001) manually as
4a66ebdc86d321cb916f25bd447a206eb2477e23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698