Handlify Accessors::FunctionGetArguments method.

src/accessors.h

Index: src/accessors.h
diff --git a/src/accessors.h b/src/accessors.h
index a7e67b524d58ee5ee10289832ad8aaf0ed0f57cb..ae56a3d444914365571c28e8ced7be99265eb5e1 100644
--- a/src/accessors.h
+++ b/src/accessors.h
@@ -78,11 +78,11 @@ class Accessors : public AllStatic {
 
   // Accessor functions called directly from the runtime system.
   static Handle<Object> FunctionGetPrototype(Handle<Object> object);
+  static Handle<Object> FunctionGetArguments(Handle<Object> object);

[Yang, 2013/07/18 12:21:18]

Call sites of this always pass a Handle<JSFunction> and expect a
Handle<JSObject> as return value. Can we reflect that?

[Michael Starzinger, 2013/07/18 13:01:03]

In general the function can return any object (e.g. undefined as well), so I
think the signature should reflect that instead of being specialized for two
particular call-sites that just happen to use it in cases where an actual
arguments-object is returned. Same applies for the argument, the function can
handle any object properly.

 
   MUST_USE_RESULT static MaybeObject* FunctionSetPrototype(JSObject* object,
                                                       Object* value,
                                                       void*);
-  static MaybeObject* FunctionGetArguments(Object* object, void*);
 
   // Accessor infos.
   static Handle<AccessorInfo> MakeModuleExport(
@@ -90,10 +90,11 @@ class Accessors : public AllStatic {
 
  private:
   // Accessor functions only used through the descriptor.
+  static MaybeObject* FunctionGetPrototype(Object* object, void*);
   static MaybeObject* FunctionGetLength(Object* object, void*);
   static MaybeObject* FunctionGetName(Object* object, void*);
+  static MaybeObject* FunctionGetArguments(Object* object, void*);
   static MaybeObject* FunctionGetCaller(Object* object, void*);
-  static MaybeObject* FunctionGetPrototype(Object* object, void*);
   MUST_USE_RESULT static MaybeObject* ArraySetLength(JSObject* object,
                                                      Object* value, void*);
   static MaybeObject* ArrayGetLength(Object* object, void*);