Handlify Accessors::FunctionGetArguments method.

src/accessors.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 60 matching lines @@
   enum DescriptorId {
 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
     k##name,
   ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION)
 #undef ACCESSOR_DESCRIPTOR_DECLARATION
     descriptorCount
   };
 
   // Accessor functions called directly from the runtime system.
   static Handle<Object> FunctionGetPrototype(Handle<Object> object);
+  static Handle<Object> FunctionGetArguments(Handle<Object> object);

[Yang, 2013/07/18 12:21:18]

Call sites of this always pass a Handle<JSFunction> and expect a
Handle<JSObject> as return value. Can we reflect that?

[Michael Starzinger, 2013/07/18 13:01:03]

In general the function can return any object (e.g. undefined as well), so I
think the signature should reflect that instead of being specialized for two
particular call-sites that just happen to use it in cases where an actual
arguments-object is returned. Same applies for the argument, the function can
handle any object properly.

 
   MUST_USE_RESULT static MaybeObject* FunctionSetPrototype(JSObject* object,
                                                       Object* value,
                                                       void*);
-  static MaybeObject* FunctionGetArguments(Object* object, void*);
 
   // Accessor infos.
   static Handle<AccessorInfo> MakeModuleExport(
       Handle<String> name, int index, PropertyAttributes attributes);
 
  private:
   // Accessor functions only used through the descriptor.
+  static MaybeObject* FunctionGetPrototype(Object* object, void*);
   static MaybeObject* FunctionGetLength(Object* object, void*);
   static MaybeObject* FunctionGetName(Object* object, void*);
+  static MaybeObject* FunctionGetArguments(Object* object, void*);
   static MaybeObject* FunctionGetCaller(Object* object, void*);
-  static MaybeObject* FunctionGetPrototype(Object* object, void*);
   MUST_USE_RESULT static MaybeObject* ArraySetLength(JSObject* object,
                                                      Object* value, void*);
   static MaybeObject* ArrayGetLength(Object* object, void*);
   static MaybeObject* StringGetLength(Object* object, void*);
   static MaybeObject* ScriptGetName(Object* object, void*);
   static MaybeObject* ScriptGetId(Object* object, void*);
   static MaybeObject* ScriptGetSource(Object* object, void*);
   static MaybeObject* ScriptGetLineOffset(Object* object, void*);
   static MaybeObject* ScriptGetColumnOffset(Object* object, void*);
   static MaybeObject* ScriptGetData(Object* object, void*);
   static MaybeObject* ScriptGetType(Object* object, void*);
   static MaybeObject* ScriptGetCompilationType(Object* object, void*);
   static MaybeObject* ScriptGetLineEnds(Object* object, void*);
   static MaybeObject* ScriptGetContextData(Object* object, void*);
   static MaybeObject* ScriptGetEvalFromScript(Object* object, void*);
   static MaybeObject* ScriptGetEvalFromScriptPosition(Object* object, void*);
   static MaybeObject* ScriptGetEvalFromFunctionName(Object* object, void*);
 
   // Helper functions.
   static Object* FlattenNumber(Object* value);
   static MaybeObject* IllegalSetter(JSObject*, Object*, void*);
   static Object* IllegalGetAccessor(Object* object, void*);
   static MaybeObject* ReadOnlySetAccessor(JSObject*, Object* value, void*);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_ACCESSORS_H_