Handlify Accessors::FunctionGetArguments method.

Handlify Accessors::FunctionGetArguments method.

R=yangguo@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15751

[Yang, 2013-07-18 12:21:18]

lgtm with comments.

https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc#newcode582
src/accessors.cc:582: isolate, Accessors::FunctionGetArguments(*object, 0),
Object);
The call sites always have a comment that this cannot return a failure. Can we
just assert it and create a handle from it directly?

https://codereview.chromium.org/19638003/diff/2001/src/accessors.h
File src/accessors.h (right):

https://codereview.chromium.org/19638003/diff/2001/src/accessors.h#newcode81
src/accessors.h:81: static Handle<Object> FunctionGetArguments(Handle<Object>
object);
Call sites of this always pass a Handle<JSFunction> and expect a
Handle<JSObject> as return value. Can we reflect that?

[Michael Starzinger, 2013-07-18 13:01:03]

https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc#newcode582
src/accessors.cc:582: isolate, Accessors::FunctionGetArguments(*object, 0),
Object);
On 2013/07/18 12:21:18, Yang wrote:
> The call sites always have a comment that this cannot return a failure. Can we
> just assert it and create a handle from it directly?

See comment in the header.

https://codereview.chromium.org/19638003/diff/2001/src/accessors.h
File src/accessors.h (right):

https://codereview.chromium.org/19638003/diff/2001/src/accessors.h#newcode81
src/accessors.h:81: static Handle<Object> FunctionGetArguments(Handle<Object>
object);
On 2013/07/18 12:21:18, Yang wrote:
> Call sites of this always pass a Handle<JSFunction> and expect a
> Handle<JSObject> as return value. Can we reflect that?

In general the function can return any object (e.g. undefined as well), so I
think the signature should reflect that instead of being specialized for two
particular call-sites that just happen to use it in cases where an actual
arguments-object is returned. Same applies for the argument, the function can
handle any object properly.

[Michael Starzinger, 2013-07-18 13:57:03]

Landing, as discussed offline.

[Michael Starzinger, 2013-07-18 14:00:59]

Committed patchset #2 manually as r15751 (presubmit successful).