Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 19637009: Revert 212459 "Remove TextDatabase from the history service." (Closed)

Created:
7 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
7 years, 5 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 212459 "Remove TextDatabase from the history service." This appears to have broken several history unit tests on Mac 10.6 AddNewRows CacheSaveRestore CursorPositionRetrieval DeleteRows ExpireRow HugeResultSet NonUniqueTermCharacterSets ProperStringMatching ReadVisitsFromHistory RebuildFromHistoryIfCacheOld Retrieval TitleChange TitleSearch TypedCharacterCaching URLPrefixMatching WhitelistedURLs Example output: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/40521/steps/unit_tests/logs/AddNewRows > Remove TextDatabase from the history service. > > The full text indexing feature is no longer used by anything. > - Remove the TextDatabase, TextDatabaseManager and related files. > - Remove is_indexed field from VisitRow objects. > - Modify ExpireHistoryBackend and HistoryBackend to no longer call TextDatabase > - Have HistoryBackend delete the "History Index *" files from the users profile > - Remove ChromeViewHostMsg_PageContents IPC message since the browser process > no longer requires to have the page contents of recently loaded pages. > > BUG=247418 > TESTS=unit tests, manual testing and run through trybots. > > Review URL: https://chromiumcodereview.appspot.com/16951015 TBR=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -110 lines) Patch
M trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/history/expire_history_backend.h View 6 chunks +15 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/history/expire_history_backend.cc View 11 chunks +81 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/history/expire_history_backend_unittest.cc View 15 chunks +133 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/history/history_backend.h View 6 chunks +13 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/history/history_backend.cc View 21 chunks +193 lines, -28 lines 0 comments Download
M trunk/src/chrome/browser/history/history_backend_unittest.cc View 8 chunks +32 lines, -41 lines 0 comments Download
M trunk/src/chrome/browser/history/history_database.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/history/history_service.h View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/history/history_service.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/history/history_tab_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/history/history_tab_helper.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/history/history_types.h View 2 chunks +11 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/history/history_types.cc View 3 chunks +5 lines, -2 lines 0 comments Download
A + trunk/src/chrome/browser/history/text_database.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/history/text_database.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/history/text_database_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/history/text_database_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/history/text_database_manager_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/history/visit_database.h View 2 chunks +7 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/history/visit_database.cc View 5 chunks +32 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/history/visit_database_unittest.cc View 3 chunks +30 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/render_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/chrome/renderer/chrome_render_view_observer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/data/History/url_history_provider_test.db.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M trunk/src/chrome/test/perf/generate_profile.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/test/perf/generate_profile.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
asargent_no_longer_on_chrome
7 years, 5 months ago (2013-07-18 23:25:28 UTC) #1
asargent_no_longer_on_chrome
7 years, 5 months ago (2013-07-18 23:25:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r212473.

Powered by Google App Engine
This is Rietveld 408576698