Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: trunk/src/chrome/browser/history/visit_database_unittest.cc

Issue 19637009: Revert 212459 "Remove TextDatabase from the history service." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/history/visit_database_unittest.cc
===================================================================
--- trunk/src/chrome/browser/history/visit_database_unittest.cc (revision 212472)
+++ trunk/src/chrome/browser/history/visit_database_unittest.cc (working copy)
@@ -29,7 +29,8 @@
a.url_id == b.url_id &&
a.visit_time == b.visit_time &&
a.referring_visit == b.referring_visit &&
- a.transition == b.transition;
+ a.transition == b.transition &&
+ a.is_indexed == b.is_indexed;
}
} // namespace
@@ -147,6 +148,7 @@
modification.transition = content::PAGE_TRANSITION_TYPED;
modification.visit_time = Time::Now() + TimeDelta::FromDays(1);
modification.referring_visit = 9292;
+ modification.is_indexed = true;
UpdateVisitRow(modification);
// Check that the mutated version was written.
@@ -385,4 +387,31 @@
EXPECT_EQ(SOURCE_EXTENSION, sources[matches[0].visit_id]);
}
+TEST_F(VisitDatabaseTest, GetIndexedVisits) {
+ // Add non-indexed visits.
+ int url_id = 111;
+ VisitRow visit_info1(
+ url_id, Time::Now(), 0, content::PAGE_TRANSITION_LINK, 0);
+ ASSERT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
+
+ VisitRow visit_info2(
+ url_id, Time::Now(), 0, content::PAGE_TRANSITION_TYPED, 0);
+ ASSERT_TRUE(AddVisit(&visit_info2, SOURCE_SYNCED));
+
+ std::vector<VisitRow> visits;
+ EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
+ EXPECT_EQ(static_cast<size_t>(2), visits.size());
+ EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
+ EXPECT_EQ(static_cast<size_t>(0), visits.size());
+
+ VisitRow visit_info3(
+ url_id, Time::Now(), 2, content::PAGE_TRANSITION_TYPED, 0);
+ visit_info3.is_indexed = true;
+ ASSERT_TRUE(AddVisit(&visit_info3, SOURCE_SYNCED));
+ EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
+ EXPECT_EQ(static_cast<size_t>(3), visits.size());
+ EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
+ EXPECT_EQ(static_cast<size_t>(1), visits.size());
+}
+
} // namespace history
« no previous file with comments | « trunk/src/chrome/browser/history/visit_database.cc ('k') | trunk/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698