Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1963693004:
[build] Use -O2 on linux by default (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 7 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Use -O2 on linux by default
This switches O2 -> O3 to match chromium's configuration.
This makes the difference between gn and gyp a bit smaller
before switching.
BUG=chromium:474921
LOG=n
Committed: https://crrev.com/a37ab71e343b8cc24df05868b941a49e0c271376
Cr-Commit-Position: refs/heads/master@{#36124}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== [build] Use -O2 on linux by default BUG= ========== to ========== [build] Use -O2 on linux by default BUG=chromium:474921 LOG=n ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963693004/1
Description was changed from ========== [build] Use -O2 on linux by default BUG=chromium:474921 LOG=n ========== to ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. BUG=chromium:474921 LOG=n ==========
PTAL. Didn't touch mac yet. Also there chromium uses level 2.
lgtm
Description was changed from ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. BUG=chromium:474921 LOG=n ========== to ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. This makes the difference between gn and gyp a bit smaller before switching. BUG=chromium:474921 LOG=n ==========
the CL comment gets it wrong. It switches O3 -> O2
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963693004/1
Message was sent while issue was closed.
Description was changed from ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. This makes the difference between gn and gyp a bit smaller before switching. BUG=chromium:474921 LOG=n ========== to ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. This makes the difference between gn and gyp a bit smaller before switching. BUG=chromium:474921 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. This makes the difference between gn and gyp a bit smaller before switching. BUG=chromium:474921 LOG=n ========== to ========== [build] Use -O2 on linux by default This switches O2 -> O3 to match chromium's configuration. This makes the difference between gn and gyp a bit smaller before switching. BUG=chromium:474921 LOG=n Committed: https://crrev.com/a37ab71e343b8cc24df05868b941a49e0c271376 Cr-Commit-Position: refs/heads/master@{#36124} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a37ab71e343b8cc24df05868b941a49e0c271376 Cr-Commit-Position: refs/heads/master@{#36124}
Message was sent while issue was closed.
This leads to a bunch of regressions. Maybe we should rather fix gn and make it work like gyp did before? I.e. chromium compiles with -O2 but V8 objects use -O3?
Message was sent while issue was closed.
On 2016/05/10 at 11:27:53, machenbach wrote: > This leads to a bunch of regressions. Maybe we should rather fix gn and make it work like gyp did before? I.e. chromium compiles with -O2 but V8 objects use -O3? yes, makes sense
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1958253004/ by machenbach@chromium.org. The reason for reverting is: Causes regressions.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
