Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: gypfiles/toolchain.gypi

Issue 1963693004: [build] Use -O2 on linux by default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/toolchain.gypi
diff --git a/gypfiles/toolchain.gypi b/gypfiles/toolchain.gypi
index ee6cd20067554e4b8bdb80916765d4acabaa1875..bb016e72a28c402edbed71272a5284682edc2406 100644
--- a/gypfiles/toolchain.gypi
+++ b/gypfiles/toolchain.gypi
@@ -1183,23 +1183,13 @@
'cflags!': [
'-O0',
'-O1',
+ '-O3',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- ],
- 'conditions': [
- # TODO(crbug.com/272548): Avoid -O3 in NaCl
- # Don't use -O3 with sanitizers.
- ['nacl_target_arch=="none" and asan==0 and msan==0 and lsan==0 \
- and tsan==0 and ubsan==0 and ubsan_vptr==0', {
- 'cflags': ['-O3'],
- 'cflags!': ['-O2'],
- }, {
- 'cflags': ['-O2'],
- 'cflags!': ['-O3'],
- }],
+ '-O2',
],
}],
['OS=="mac"', {
@@ -1301,24 +1291,14 @@
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \
or OS=="aix"', {
'cflags!': [
+ '-O3',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
'<(wno_array_bounds)',
- ],
- 'conditions': [
- # TODO(crbug.com/272548): Avoid -O3 in NaCl
- # Don't use -O3 with sanitizers.
- ['nacl_target_arch=="none" and asan==0 and msan==0 and lsan==0 \
- and tsan==0 and ubsan==0 and ubsan_vptr==0', {
- 'cflags': ['-O3'],
- 'cflags!': ['-O2'],
- }, {
- 'cflags': ['-O2'],
- 'cflags!': ['-O3'],
- }],
+ '-O2',
],
}],
['OS=="android"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698