Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1963693003: Revert of Correctly handle damage involving filters in SurfaceAggregator (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Correctly handle damage involving filters in SurfaceAggregator (patchset #6 id:100001 of https://codereview.chromium.org/1927413002/ ) Reason for revert: Seems to cause rendering issues on mac. BUG=610181 Original issue's description: > Correctly handle damage involving filters in SurfaceAggregator > > There are two main issues with the handling of damage of contents > affected by RenderPassDrawQuad filters: > 1) Damage of a small part of a source Surface can affect a large part > of the destination and > 2) To draw damage on the destination, an unexpectedly large portion > of the source must be used. > > To deal with these, the SurfaceAggregator must keep track of all output > render passes affected by filters. Any Surface in an affected RenderPass > will cause its parent Surface to be completely damaged (handling #1 > above). > > To handle #2, affected RenderPasses will have their damage rects set to > contain the entire output_rect. Then DirectRenderer can use that damage > rect to determine what to draw. > > CopyRequests can also cause areas outside the damage rect to be read, so > any RenderPass inside a CopyRequest (directly or indirectly) will have > its damage rect set to the output rect. > > This system is very pessimistic about what should be drawn, but in > general it shouldn't affect that many cases and should always be > correct. > > BUG=602941 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/575a9b96a2b2776a6a4ae81f2e20c2bf3e975250 > Cr-Commit-Position: refs/heads/master@{#391733} TBR=piman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602941 Committed: https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081 Cr-Commit-Position: refs/heads/master@{#392445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -259 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator.h View 4 chunks +2 lines, -21 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 13 chunks +18 lines, -113 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 5 chunks +8 lines, -114 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbauman
Created Revert of Correctly handle damage involving filters in SurfaceAggregator
4 years, 7 months ago (2016-05-09 21:20:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963693003/1
4 years, 7 months ago (2016-05-09 21:21:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 22:18:02 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:19:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081
Cr-Commit-Position: refs/heads/master@{#392445}

Powered by Google App Engine
This is Rietveld 408576698