Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: ash/system/user/user_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/tray_popup_label_button.cc ('k') | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/user/user_view.cc
diff --git a/ash/system/user/user_view.cc b/ash/system/user/user_view.cc
index 312d5a3cb675afa876d22b1df7818d2f557144b7..f1eed28be4b2276c083943c1e2629f3cd45444b3 100644
--- a/ash/system/user/user_view.cc
+++ b/ash/system/user/user_view.cc
@@ -405,8 +405,6 @@ void UserView::AddUserCard(user::LoginStatus login) {
}
auto* button =
new ButtonFromView(contents_view, this, !user_index_, insets);
- // A click on the button should not trigger a focus change.
- button->set_request_focus_on_press(false);
user_card_view_ = button;
is_user_card_button_ = true;
}
@@ -461,7 +459,6 @@ void UserView::ToggleAddUserMenuOption() {
add_user_enabled_ ? this : NULL,
add_user_enabled_,
gfx::Insets(1, 1, 1, 1));
- button->set_request_focus_on_press(false);
button->SetAccessibleName(
l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT));
button->ForceBorderVisible(true);
« no previous file with comments | « ash/system/tray/tray_popup_label_button.cc ('k') | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698