ash/system/tray/tray_popup_label_button.cc - Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/tray/tray_popup_label_button.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/tray/tray_popup_label_button.cc

diff --git a/ash/system/tray/tray_popup_label_button.cc b/ash/system/tray/tray_popup_label_button.cc

index 02fa9544e6eaca5ea94fa88820d223a49092f802..2fea3bdca2543cd8347ffc0f04e5c20441605bd3 100644

--- a/ash/system/tray/tray_popup_label_button.cc

+++ b/ash/system/tray/tray_popup_label_button.cc

@@ -17,7 +17,6 @@ TrayPopupLabelButton::TrayPopupLabelButton(views::ButtonListener* listener,

: views::LabelButton(listener, text) {

SetBorder(std::unique_ptr<views::Border>(new TrayPopupLabelButtonBorder));

Button::ConfigureDefaultFocus(this);

- set_request_focus_on_press(false);

set_animate_on_state_change(false);

SetHorizontalAlignment(gfx::ALIGN_CENTER);

SetFocusPainter(views::Painter::CreateSolidFocusPainter(

« no previous file with comments | « ash/system/tray/tray_popup_header_button.cc ('k') | ash/system/user/user_view.cc » ('j') | no next file with comments »