More tweaks for 'for' completion.

More tweaks for 'for' completion.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cd7b7fc018ab6248ea08d4840fc91e0f6232ceeb

[Brian Wilkerson, 2016-05-10 22:29:08]

lgtm

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/dart/optype.dart (right):

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/optype.dart:488:
optype.includeTypeNameSuggestions = true;
Seems unlikely to me that we'd want a type in either the condition or the
updaters, but maybe I'm wrong.

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:693:
Block_final() async {
Should we mark this as "fail_" rather than not running it at all?

[scheglov, 2016-05-11 03:22:18]

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1963323003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:693:
Block_final() async {
On 2016/05/10 22:29:08, Brian Wilkerson wrote:
> Should we mark this as "fail_" rather than not running it at all?

Thank you.
I must have removed "test_" accidentally.

[scheglov, 2016-05-11 03:22:20]

Description was changed from

==========
More tweaks for 'for' completion.

R=brianwilkerson@google.com
BUG=
==========

to

==========
More tweaks for 'for' completion.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cd7b7fc018ab6248ea08d4840fc91e0f6232ceeb
==========

[scheglov, 2016-05-11 03:22:22]

Committed patchset #1 (id:1) manually as
cd7b7fc018ab6248ea08d4840fc91e0f6232ceeb (presubmit successful).