Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: pkg/analysis_server/test/services/completion/dart/optype_test.dart

Issue 1963323003: More tweaks for 'for' completion. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/optype_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/optype_test.dart b/pkg/analysis_server/test/services/completion/dart/optype_test.dart
index 02846a2da2dfee46d387f68f0908251affbeb57b..9a6982b63fa48dc5b571d294627c6e8ef0907d61 100644
--- a/pkg/analysis_server/test/services/completion/dart/optype_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/optype_test.dart
@@ -668,15 +668,13 @@ class OpTypeTest {
test_ForStatement_condition() {
// SimpleIdentifier ForStatement
addTestSource('main() {for (int index = 0; i^)}');
- // TODO (danrubel) may want to exclude methods/functions with void return
- assertOpType(returnValue: true, typeNames: true, voidReturn: true);
+ assertOpType(returnValue: true, typeNames: true);
}
test_ForStatement_initializer() {
// SimpleIdentifier ForStatement
addTestSource('main() {List a; for (^)}');
- // TODO (danrubel) may want to exclude methods/functions with void return
- assertOpType(returnValue: true, typeNames: true, voidReturn: true);
+ assertOpType(typeNames: true);
}
test_ForStatement_initializer_inKeyword() {
@@ -684,6 +682,12 @@ class OpTypeTest {
assertOpType();
}
+ test_ForStatement_initializer_type() {
+ // SimpleIdentifier ForStatement
+ addTestSource('main() {List a; for (i^ v = 0;)}');
+ assertOpType(typeNames: true);
+ }
+
test_ForStatement_initializer_variableNameEmpty_afterType() {
addTestSource('main() { for (String ^) }');
assertOpType(varNames: true);

Powered by Google App Engine
This is Rietveld 408576698