Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1963253002:
[Mac/GN][sanitizers] Copy the ASan runtime to the output directory. (Closed)
|
Created:
4 years, 7 months ago by Robert Sesek Modified:
4 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac/GN][sanitizers] Copy the ASan runtime to the output directory.
This sets it as a data_deps so that any targets depending on the sanitizer
will also pick up the runtime file when being isolated.
Because the ASan runtime uses @loader_path this will not work for bundled
targets, only standalone executables.
BUG=597066, 431177
R=aizatsky@chromium.org
Committed: https://crrev.com/45384fb36763bb34ac3a7395d2dc941754a276ae
Cr-Commit-Position: refs/heads/master@{#393335}
Patch Set 1 : #
Total comments: 2
Messages
Total messages: 21 (9 generated)
Description was changed from ========== [Mac/GN][sanitizers] Copy the clang runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. BUG=597066,431177 R=aizatsky@chromium.org ========== to ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. BUG=597066,431177 R=aizatsky@chromium.org ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by aizatsky@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963253002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rsesek@chromium.org changed reviewers: + thakis@chromium.org
+thakis for //base and //build OWNERS
https://code.google.com/p/chromium/codesearch#chromium/src/build/mac/copy_asa... does install name munging, is that not needed in gn? https://codereview.chromium.org/1963253002/diff/20001/base/BUILD.gn File base/BUILD.gn (left): https://codereview.chromium.org/1963253002/diff/20001/base/BUILD.gn#oldcode1295 base/BUILD.gn:1295: } I think the reason this was here is probably because base.isolate lists this (https://code.google.com/p/chromium/codesearch#chromium/src/base/base.isolate&...). base/BUILD.gn also copies all the Windows dlls to the build output dir (https://code.google.com/p/chromium/codesearch#chromium/src/base/BUILD.gn&l=1190).
On 2016/05/10 21:43:37, Nico wrote: > https://code.google.com/p/chromium/codesearch#chromium/src/build/mac/copy_asa... > does install name munging, is that not needed in gn? That's for bundled targets, which I haven't decided how to make work with ASan yet. This is covering non-bundled executables. https://codereview.chromium.org/1963253002/diff/20001/base/BUILD.gn File base/BUILD.gn (left): https://codereview.chromium.org/1963253002/diff/20001/base/BUILD.gn#oldcode1295 base/BUILD.gn:1295: } On 2016/05/10 21:43:37, Nico wrote: > I think the reason this was here is probably because base.isolate lists this > (https://code.google.com/p/chromium/codesearch#chromium/src/base/base.isolate&...). > base/BUILD.gn also copies all the Windows dlls to the build output dir > (https://code.google.com/p/chromium/codesearch#chromium/src/base/BUILD.gn&l=1190). In GN, the isolate files are built from the data[] lists on targets. Because this depends on the //build/config/sanitizer:deps it gets the data_deps[] from that target, which includes the ASan runtime. That way all targets that depend on the sanitizers should get the runtime as a data[].
lgtm, but maybe mention in the cl description that this doesn't work for bundles yet.
Description was changed from ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. BUG=597066,431177 R=aizatsky@chromium.org ========== to ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. Because the ASan runtime uses @loader_path this will not work for bundled targets, only standalone executables. BUG=597066,431177 R=aizatsky@chromium.org ==========
On 2016/05/12 18:37:52, Nico wrote: > lgtm, but maybe mention in the cl description that this doesn't work for bundles > yet. done
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963253002/20001
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. Because the ASan runtime uses @loader_path this will not work for bundled targets, only standalone executables. BUG=597066,431177 R=aizatsky@chromium.org ========== to ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. Because the ASan runtime uses @loader_path this will not work for bundled targets, only standalone executables. BUG=597066,431177 R=aizatsky@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. Because the ASan runtime uses @loader_path this will not work for bundled targets, only standalone executables. BUG=597066,431177 R=aizatsky@chromium.org ========== to ========== [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. This sets it as a data_deps so that any targets depending on the sanitizer will also pick up the runtime file when being isolated. Because the ASan runtime uses @loader_path this will not work for bundled targets, only standalone executables. BUG=597066,431177 R=aizatsky@chromium.org Committed: https://crrev.com/45384fb36763bb34ac3a7395d2dc941754a276ae Cr-Commit-Position: refs/heads/master@{#393335} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/45384fb36763bb34ac3a7395d2dc941754a276ae Cr-Commit-Position: refs/heads/master@{#393335} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
