Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: base/BUILD.gn

Issue 1963253002: [Mac/GN][sanitizers] Copy the ASan runtime to the output directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index c5bcc1d619258a710b7457b098470a7f8127ed80..67fac3c88b70e0240abffa7c430ac2343c7b0d20 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1288,11 +1288,6 @@ component("base") {
"strings/sys_string_conversions_posix.cc",
"threading/platform_thread_internal_posix.cc",
]
-
- if (is_asan) {
- # TODO(GYP) hook up asan on Mac. GYP has this extra dylib:
- #data += [ "$root_out_dir/libclang_rt.asan_osx_dynamic.dylib" ]
- }
Nico 2016/05/10 21:43:37 I think the reason this was here is probably becau
Robert Sesek 2016/05/12 18:35:45 In GN, the isolate files are built from the data[]
} else {
# Non-Mac/ios.
sources -= [
« no previous file with comments | « no previous file | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698