Support 'extend-to-zoom' viewport descriptor value

Support 'extend-to-zoom' viewport descriptor value

Based on patch from Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>;.

See http://dev.w3.org/csswg/css-device-adapt for details.

This new feature is enabled only for UA and user style sheets.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154511

[kenneth.r.christiansen, 2013-07-17 16:44:30]

generally looks good, a few nits. lgtm

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
File LayoutTests/css3/device-adapt/viewport-initial-height-zero.html (right):

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
LayoutTests/css3/device-adapt/viewport-initial-height-zero.html:14:
testRunner.addUserStyleSheet("@viewport { width: extend-to-zoom 980px; min-zoom:
0.25; max-zoom: 5; }", true);
It is saver to add the other values as well with "auto" to override any UA set
values. Rune also did this in the opera viewport tests. I think for user-zoom
you need to use 'zoom'

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
File LayoutTests/css3/device-adapt/viewport-insert-rule-after.html (right):

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
LayoutTests/css3/device-adapt/viewport-insert-rule-after.html:12:
testRunner.addUserStyleSheet("@viewport { width: extend-to-zoom 980px; min-zoom:
0.25; max-zoom: 5; }", true);
indentation seems wrong and can't this be merged with the other
window.testRunner if

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
File LayoutTests/css3/device-adapt/viewport-insert-rule-before.html (right):

https://codereview.chromium.org/19632002/diff/1/LayoutTests/css3/device-adapt...
LayoutTests/css3/device-adapt/viewport-insert-rule-before.html:12:
testRunner.addUserStyleSheet("@viewport { width: extend-to-zoom 980px; min-zoom:
0.25; max-zoom: 5; }", true);
same

https://codereview.chromium.org/19632002/diff/1/Source/core/css/CSSParser-in.cpp
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/19632002/diff/1/Source/core/css/CSSParser-in....
Source/core/css/CSSParser-in.cpp:11437: if (id == CSSValueAuto || id ==
CSSValueExtendToZoom)
We need this to be an internal value. What you can only add in user sheets/UA's
etc need to be prefixed with -internal-. Yes, I didnt do that in my patch, but
Rune pointed it out

https://codereview.chromium.org/19632002/diff/1/Source/core/css/CSSValueKeywo...
File Source/core/css/CSSValueKeywords.in (right):

https://codereview.chromium.org/19632002/diff/1/Source/core/css/CSSValueKeywo...
Source/core/css/CSSValueKeywords.in:990: extend-to-zoom
-internal-extend-to-zoom

[kenneth.r.christiansen, 2013-07-17 16:49:52]

Please add a specific test for this, actually at least two, so that you test it
with width and with height, but you can make even more combinations if you think
a bit :-)

[kenneth.r.christiansen, 2013-07-18 14:55:35]

I would like one test for width: extend-to-zoom; which is a shorthand for
"width: extend-to-zoom extend-to-zoom;" It's even used in the spec for meta tag
conversion:

---
For a viewport META element that translates into an @viewport rule with a
non-‘auto’ ‘zoom’ declaration and no ‘width’ declaration:

If it adds a ‘height’ descriptor, add:

width: auto;

Otherwise, add:

width: extend-to-zoom;

to the @viewport rule.
---

https://codereview.chromium.org/19632002/diff/8001/LayoutTests/css3/device-ad...
File LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html (right):

https://codereview.chromium.org/19632002/diff/8001/LayoutTests/css3/device-ad...
LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html:17:
testRunner.addUserStyleSheet("@viewport { width: -internal-extend-to-zoom 980px;
min-zoom: 0.25; max-zoom: 5; height: auto ; zoom: auto; }", true);
There is no auto for zoom, according to the spec

[Mikhail, 2013-07-18 15:16:06]

On 2013/07/18 14:55:35, kenneth.r.christiansen wrote:
> I would like one test for width: extend-to-zoom; which is a shorthand for
> "width: extend-to-zoom extend-to-zoom;" 
I think LayoutTests/css3/device-adapt/viewport-width-extend-to-zoom.html has it.
> It's even used in the spec for meta tag
> conversion:
> 
> ---
> For a viewport META element that translates into an @viewport rule with a
> non-‘auto’ ‘zoom’ declaration and no ‘width’ declaration:
> 
> If it adds a ‘height’ descriptor, add:
> 
> width: auto;
> 
> Otherwise, add:
> 
> width: extend-to-zoom;
> 
> to the @viewport rule.
> ---
> 
>
https://codereview.chromium.org/19632002/diff/8001/LayoutTests/css3/device-ad...
> File LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html
(right):
> 
>
https://codereview.chromium.org/19632002/diff/8001/LayoutTests/css3/device-ad...
> LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html:17:
> testRunner.addUserStyleSheet("@viewport { width: -internal-extend-to-zoom
980px;
> min-zoom: 0.25; max-zoom: 5; height: auto ; zoom: auto; }", true);
> There is no auto for zoom, according to the spec
'zoom' has 'user-zoom' does not, however 'user-zoom' also should be reset, I'll
update patch accordingly

[apavlov, 2013-07-18 16:06:17]

https://codereview.chromium.org/19632002/diff/13001/Source/core/css/CSSParser...
File Source/core/css/CSSParser-in.cpp (left):

https://codereview.chromium.org/19632002/diff/13001/Source/core/css/CSSParser...
Source/core/css/CSSParser-in.cpp:11409: if
(!RuntimeEnabledFeatures::cssViewportEnabled())
Has this removal been agreed upon? Looking at CSSParser-in.cpp, I can see the
following in bool CSSParser::parseValue(CSSPropertyID propId, bool important):

    if (inViewport()) {
        if (!RuntimeEnabledFeatures::cssViewportEnabled())
            return false;

        return parseViewportProperty(propId, important);
    }

So, it looks like this case will still be non-functional...

https://codereview.chromium.org/19632002/diff/13001/Source/core/dom/ViewportA...
File Source/core/dom/ViewportArguments.cpp (right):

https://codereview.chromium.org/19632002/diff/13001/Source/core/dom/ViewportA...
Source/core/dom/ViewportArguments.cpp:169: switch (int(resultWidth)) {
I guess you should use static_cast<int>() or floor(), or something similar, as
we don't use this way of value construction (or operator() casts, like ((int)
resultWidth) ).

https://codereview.chromium.org/19632002/diff/13001/Source/core/dom/ViewportA...
Source/core/dom/ViewportArguments.cpp:178: switch (int(resultHeight)) {
ditto

[kenneth.r.christiansen, 2013-07-18 16:36:54]

lgtm

[apavlov, 2013-07-18 16:56:28]

lgtm

[commit-bot: I haz the power, 2013-07-18 18:50:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/19632002/...

[commit-bot: I haz the power, 2013-07-18 20:09:06]

Change committed as 154511