Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 1963193002: Ink Drop cleanup. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ink Drop cleanup. Some stuff got missed in the original CL here: https://codereview.chromium.org/1937353002. BUG=608423 Committed: https://crrev.com/225a87231b3c0e81f17faebf241f5b548b2b1c1c Cr-Commit-Position: refs/heads/master@{#393277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed tdanderson@ nit from patch set 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -377 lines) Patch
D ui/views/animation/ink_drop_animation_controller_impl.cc View 1 chunk +0 lines, -259 lines 0 comments Download
M ui/views/animation/ink_drop_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
D ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M ui/views/animation/test/ink_drop_hover_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/ink_drop_impl_test_api.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
bruthig
tdanderson@, can you provide a second set of eyes on this?
4 years, 7 months ago (2016-05-10 18:42:31 UTC) #2
tdanderson
lgtm with one comment https://codereview.chromium.org/1963193002/diff/1/ui/views/animation/test/ink_drop_impl_test_api.h File ui/views/animation/test/ink_drop_impl_test_api.h (right): https://codereview.chromium.org/1963193002/diff/1/ui/views/animation/test/ink_drop_impl_test_api.h#newcode31 ui/views/animation/test/ink_drop_impl_test_api.h:31: explicit InkDropImplTestApi(InkDropImpl* ink_drop_); No _ ...
4 years, 7 months ago (2016-05-10 18:51:47 UTC) #3
bruthig
https://codereview.chromium.org/1963193002/diff/1/ui/views/animation/test/ink_drop_impl_test_api.h File ui/views/animation/test/ink_drop_impl_test_api.h (right): https://codereview.chromium.org/1963193002/diff/1/ui/views/animation/test/ink_drop_impl_test_api.h#newcode31 ui/views/animation/test/ink_drop_impl_test_api.h:31: explicit InkDropImplTestApi(InkDropImpl* ink_drop_); On 2016/05/10 18:51:46, tdanderson wrote: > ...
4 years, 7 months ago (2016-05-10 18:55:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963193002/20001
4 years, 7 months ago (2016-05-10 18:56:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180622)
4 years, 7 months ago (2016-05-10 19:06:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963193002/20001
4 years, 7 months ago (2016-05-10 19:15:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180629)
4 years, 7 months ago (2016-05-10 19:24:00 UTC) #13
bruthig
sky@, can you PTAL? I'm not sure why chrome_presubmit bot is failing when I am ...
4 years, 7 months ago (2016-05-10 20:35:25 UTC) #15
sky
Not sure, LGTM
4 years, 7 months ago (2016-05-12 15:20:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963193002/20001
4 years, 7 months ago (2016-05-12 16:18:39 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 17:05:45 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 17:07:28 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/225a87231b3c0e81f17faebf241f5b548b2b1c1c
Cr-Commit-Position: refs/heads/master@{#393277}

Powered by Google App Engine
This is Rietveld 408576698