Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1937353002: Rename of InkDropAnimationController classes to InkDrop. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename of InkDropAnimationController classes to InkDrop. DEPENDS ON: https://codereview.chromium.org/1937103003/ The term 'AnimationController' was too verbose and didn't add any value. BUG=608423 Committed: https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f Cr-Commit-Position: refs/heads/master@{#391641}

Patch Set 1 #

Patch Set 2 : Merge with master. #

Total comments: 4

Patch Set 3 : Addressed tdanderson@ comments from patch set 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -913 lines) Patch
M chrome/browser/ui/views/toolbar/back_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/button_ink_drop_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/button_ink_drop_delegate.cc View 4 chunks +8 lines, -11 lines 0 comments Download
A + ui/views/animation/ink_drop.h View 3 chunks +7 lines, -7 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller_factory.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller_factory.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller_factory_unittest.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller_impl.h View 1 chunk +0 lines, -142 lines 0 comments Download
D ui/views/animation/ink_drop_animation_controller_impl_unittest.cc View 1 chunk +0 lines, -241 lines 0 comments Download
A ui/views/animation/ink_drop_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ui/views/animation/ink_drop_factory.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A ui/views/animation/ink_drop_factory_unittest.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A + ui/views/animation/ink_drop_impl.h View 4 chunks +17 lines, -18 lines 0 comments Download
A + ui/views/animation/ink_drop_impl.cc View 1 14 chunks +31 lines, -37 lines 0 comments Download
A + ui/views/animation/ink_drop_impl_unittest.cc View 5 chunks +53 lines, -63 lines 0 comments Download
A + ui/views/animation/test/ink_drop_impl_test_api.h View 2 chunks +17 lines, -18 lines 0 comments Download
A + ui/views/animation/test/ink_drop_impl_test_api.cc View 1 2 chunks +14 lines, -18 lines 0 comments Download
M ui/views/views.gyp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bruthig
tdanderson@, Can you PTAL?
4 years, 7 months ago (2016-05-02 20:16:06 UTC) #3
tdanderson
lgtm, two comments below https://codereview.chromium.org/1937353002/diff/20001/ui/views/animation/ink_drop_factory.cc File ui/views/animation/ink_drop_factory.cc (right): https://codereview.chromium.org/1937353002/diff/20001/ui/views/animation/ink_drop_factory.cc#newcode20 ui/views/animation/ink_drop_factory.cc:20: // A stub implementation of ...
4 years, 7 months ago (2016-05-04 14:19:24 UTC) #4
bruthig
sky@, please review changes in: - chrome/browser/ui/views/toolbar/back_button.cc - ui/views/views.gyp https://codereview.chromium.org/1937353002/diff/20001/ui/views/animation/ink_drop_factory.cc File ui/views/animation/ink_drop_factory.cc (right): https://codereview.chromium.org/1937353002/diff/20001/ui/views/animation/ink_drop_factory.cc#newcode20 ui/views/animation/ink_drop_factory.cc:20: ...
4 years, 7 months ago (2016-05-04 17:55:13 UTC) #6
sky
LGTM
4 years, 7 months ago (2016-05-04 20:37:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937353002/40001
4 years, 7 months ago (2016-05-04 21:00:05 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 21:05:27 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 21:08:03 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0b9c5c0f873d94b4330352d32065ab2fdaf092f
Cr-Commit-Position: refs/heads/master@{#391641}

Powered by Google App Engine
This is Rietveld 408576698