Issue 19631003: Add named links to dependent_code in Map objects in heap snapshot.

Issue 19631003: Add named links to dependent_code in Map objects in heap snapshot. (Closed)

Created:
7 years, 5 months ago by alph

Modified:
7 years, 5 months ago

Reviewers:
ulan, yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add named links to dependent_code in Map objects in heap snapshot. R=loislo@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15752

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/heap-snapshot-generator.cc	View		2 chunks	+5 lines, -1 line	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.cc#newcode1151 src/heap-snapshot-generator.cc:1151: SetInternalReference(map, entry, Note that objects in dependent_code and ...

7 years, 5 months ago (2013-07-18 10:55:59 UTC) #3

alph

Committed patchset #1 manually as r15752 (presubmit successful).

7 years, 5 months ago (2013-07-18 14:15:11 UTC) #4

alph

https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.cc#newcode1151 src/heap-snapshot-generator.cc:1151: SetInternalReference(map, entry, On 2013/07/18 10:56:00, ulan wrote: > Note ...

7 years, 5 months ago (2013-07-18 14:17:37 UTC) #5

ulan

7 years, 5 months ago (2013-07-18 15:01:46 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/19631003/diff/1/src/heap-snapshot-generator.c...
src/heap-snapshot-generator.cc:1151: SetInternalReference(map, entry,
On 2013/07/18 14:17:37, alph wrote:
> On 2013/07/18 10:56:00, ulan wrote:
> > Note that objects in dependent_code and transitions are weakly referenced.
> 
> I'm curious where does this knowledge come from. AFAICT DependentCode object
is
> indistinguishable from regular FixedArray. So how does GC know that?
It is in StaticMarkingVisitor<StaticVisitor>::MarkMapContents()

Expand Messages | Collapse Messages