Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: src/heap-snapshot-generator.cc

Issue 19631003: Add named links to dependent_code in Map objects in heap snapshot. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index 15e0a7ccef3bf2085e28c2c6bc691ed0b44ea69d..316b36a3ab613c511317234e237d629c98848639 100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -892,7 +892,7 @@ class IndexedReferencesExtractor : public ObjectVisitor {
: generator_(generator),
parent_obj_(parent_obj),
parent_(parent),
- next_index_(1) {
+ next_index_(0) {
}
void VisitCodeEntry(Address entry_address) {
Code* code = Code::cast(Code::GetObjectFromEntryAddress(entry_address));
@@ -1147,6 +1147,10 @@ void V8HeapExplorer::ExtractMapReferences(int entry, Map* map) {
SetInternalReference(map, entry,
"constructor", map->constructor(),
Map::kConstructorOffset);
+ TagObject(map->dependent_code(), "(dependent code)");
+ SetInternalReference(map, entry,
ulan 2013/07/18 10:56:00 Note that objects in dependent_code and transition
alph 2013/07/18 14:17:37 I'm curious where does this knowledge come from. A
ulan 2013/07/18 15:01:46 It is in StaticMarkingVisitor<StaticVisitor>::Mark
+ "dependent_code", map->dependent_code(),
+ Map::kDependentCodeOffset);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698